From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Physical keyboard events Date: Mon, 04 Nov 2024 15:29:43 +0200 Message-ID: <86ed3runy0.fsf@gnu.org> References: <31bdc55d-8c13-4de0-9cef-bd6cc4fb033f@imayhem.com> <19ab52d0-88bd-4378-8fa8-8603e01233e3@imayhem.com> <871pzrl4sn.fsf@yahoo.com> <87o72vjk1f.fsf@yahoo.com> <98cd8b43-69a7-499e-94f1-3cec298d912b@imayhem.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34169"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: Cecilio Pardo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 04 14:30:27 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7xA1-0008h7-I9 for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Nov 2024 14:30:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7x9Q-0003eK-Up; Mon, 04 Nov 2024 08:29:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7x9P-0003ds-B6 for emacs-devel@gnu.org; Mon, 04 Nov 2024 08:29:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7x9O-0000tu-Ne; Mon, 04 Nov 2024 08:29:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1LDUOTmY8AvdYlerVp4etM4oGLEk++UHqq7vU2iunAA=; b=Ddwtlh2yISmz aopWj6CvANQImyi19sp0cZXAraz4Yelo20WhrA8ldbvT4O4C4QsqIpd16COFbZUED9tuUgKNua7ZR l+mV2V/js7BWHJ9PO3SRHlWB6EWd7+0aGfAz2g0mlo/uTKhMepLHSNvrEgoAv4iVM93jDeTQMGl1G wIW5zN8Vberpn7AiQKEqMb843yQYQ3FxLihkH1pPbmVQrGqNIE42DOJvbJ8HQ1GJlUNITHs0W9GCM AsRxQFEuREB5vM53sad0wd0HsuGr5FwbLXRHcxhhpR4gSOE/idql2aHSXf2XhCxF+rBmgDwzZ5hop 8bR8hykh1W9wnH7O+IsRFA==; In-Reply-To: <98cd8b43-69a7-499e-94f1-3cec298d912b@imayhem.com> (message from Cecilio Pardo on Mon, 4 Nov 2024 12:59:54 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325102 Archived-At: > Date: Mon, 4 Nov 2024 12:59:54 +0100 > Cc: emacs-devel@gnu.org > From: Cecilio Pardo > > >> Is this feature worth the changes I propose. For me it is. > > > > Well, for us that is contingent on whether they are implemented > > properly. A feature that is adequate for half of our users, will > > confuse many of them, or with the sacrifices entailed by GTK, does not > > measure up to this standard, alas. > > Ok then. > > Thanks for your time. I hope you didn't take Po Lu's response as a rejection of your proposed patch. Given that you can incorporate his review comments regarding the place to call x_maybe_send_physical_key_event, I see no reason for us not to accept such a feature, once cleaned up and properly documented. Also, please recall that I preferred these events to be blocked (a.k.a. "discarded") subject to a special variable, instead of being inserted into the input queue and then ignored due to some keymap. IOW, I'd prefer this to behave like track-mouse. Thanks.