unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Joost Kremers <joostkremers@fastmail.fm>
To: Eli Zaretskii <eliz@gnu.org>
Cc: James Cherti <contact@jamescherti.com>,  emacs-devel@gnu.org
Subject: Re: Should text-scale trigger hooks?
Date: Thu, 07 Nov 2024 09:21:01 +0100	[thread overview]
Message-ID: <86ed3ne9oy.fsf@fastmail.fm> (raw)
In-Reply-To: <86r07nr0qw.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Nov 2024 08:55:51 +0200")

On Thu, Nov 07 2024, Eli Zaretskii wrote:
> The functions which manipulate face-remapping-alist force redisplay of
> the buffer in which the alist was changed, and from Emacs display POV
> this is the only thing that should happen to make sure the affected
> buffer's display is redrawn.  Please explain why buffer's redisplay is
> not enough for the packages you mention to do their job.

Speaking for `visual-fill-column`: it's a package that adjusts the text
margins in wide windows. The goal is to have buffers that use
visual-line-mode wrap text at `fill-column`, not at the window's edge. If
the window configuration or size changes, the width of the margins needs to
be recalculated, so the package puts a function on the relevant hooks to do
that.

If the text size is changed, the window margins also need to be
recalculated, but this does not happen automatically. The README of
`visual-fill-column` suggests to advise the function
`text-scale-adjust` to solve this (see
https://codeberg.org/joostkremers/visual-fill-column#adjusting-text-size),
but it's an ad hoc solution, of course.

-- 
Joost Kremers
Life has its moments



  reply	other threads:[~2024-11-07  8:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07  1:17 Should text-scale trigger hooks? James Cherti
2024-11-07  1:52 ` James Cherti
2024-11-07  6:55 ` Eli Zaretskii
2024-11-07  8:21   ` Joost Kremers [this message]
2024-11-07  8:58     ` Eli Zaretskii
2024-11-07  9:42       ` Joost Kremers
2024-11-07 14:16         ` James Cherti
2024-11-08 17:47           ` [External] : " Drew Adams
2024-11-07  8:10 ` Joost Kremers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ed3ne9oy.fsf@fastmail.fm \
    --to=joostkremers@fastmail.fm \
    --cc=contact@jamescherti.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).