From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: improve "next locus from " messages Date: Thu, 04 Apr 2019 05:41:30 -0800 Message-ID: <86d0m1dh11.fsf@stephe-leake.org> References: <86sguzc71f.fsf@stephe-leake.org> <83y34rc5ns.fsf@gnu.org> <86o95mdd4a.fsf@stephe-leake.org> <86h8bedbso.fsf@stephe-leake.org> <87ef6iunny.fsf@ulti.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="154437"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 04 16:03:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hC2xq-000dxo-HG for ged-emacs-devel@m.gmane.org; Thu, 04 Apr 2019 16:03:34 +0200 Original-Received: from localhost ([127.0.0.1]:55278 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC2xp-0007Bp-IX for ged-emacs-devel@m.gmane.org; Thu, 04 Apr 2019 10:03:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC2x4-00077k-3F for emacs-devel@gnu.org; Thu, 04 Apr 2019 10:02:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hC2x0-0003tz-8l for emacs-devel@gnu.org; Thu, 04 Apr 2019 10:02:46 -0400 Original-Received: from gproxy10-pub.mail.unifiedlayer.com ([69.89.20.226]:44640) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hC2x0-0003qS-0n for emacs-devel@gnu.org; Thu, 04 Apr 2019 10:02:42 -0400 Original-Received: from cmgw11.unifiedlayer.com (unknown [10.9.0.11]) by gproxy10.mail.unifiedlayer.com (Postfix) with ESMTP id ED2C0141707 for ; Thu, 4 Apr 2019 07:41:34 -0600 (MDT) Original-Received: from host114.hostmonster.com ([74.220.207.114]) by cmsmtp with ESMTP id C2cYhyfhyVLCbC2cYhSyus; Thu, 04 Apr 2019 07:41:34 -0600 X-Authority-Reason: nr=8 X-Authority-Analysis: $(_cmae_reason Original-Received: from [76.77.182.20] (port=64556 helo=Takver4) by host114.hostmonster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hC2cY-000iNt-Ji for emacs-devel@gnu.org; Thu, 04 Apr 2019 07:41:34 -0600 In-Reply-To: <87ef6iunny.fsf@ulti.tmit.bme.hu> (Felician Nemeth's message of "Thu, 04 Apr 2019 11:26:09 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host114.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1hC2cY-000iNt-Ji X-Source-Sender: (Takver4) [76.77.182.20]:64556 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 1 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDExNC5ob3N0bW9uc3Rlci5jb20= X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 69.89.20.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234952 Archived-At: Felician Nemeth writes: >>>>> The attached patch changes it so the message is only output when the >>>>> locus changes. > >>>>> Comments? > > I'm not completely sure, but the proposed patch seems to assume that > next-error is only called from compilation-start. No, that assumption is not made. I added the message in compilation-start because otherwise it does not print a message when the locus is changed. I did not search the rest of emacs for places that set next-error-last-buffer, so there may be other places that need a message. Yes; xref--xref-buffer-mode sets next-error-last-buffer without a message. It makes sense to print a message only when the error locus change might be unexpected. If the user has started a compilation, they expect error messages to come from *compilation*; similarly for *xref*. The original discussion included things like flymake, which is invoked in the background. I'll take out the message in compilation-start. -- -- Stephe