From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Mingrone Newsgroups: gmane.emacs.devel Subject: Re: master 9cef8fc: Ensure that new emacsclient frames has focus Date: Fri, 18 Dec 2020 12:54:58 -0400 Message-ID: <86czz7836l.fsf@phe.ftfl.ca> References: <20201207132953.16701.29090@vcs0.savannah.gnu.org> <20201207132955.05FD720A1C@vcs0.savannah.gnu.org> <86lfdwkx5v.fsf@phe.ftfl.ca> <87y2hvjyor.fsf@gnus.org> <87tusjjwh1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34129"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (berkeley-unix) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 18 17:56:18 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqJ3C-0008m7-2v for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Dec 2020 17:56:18 +0100 Original-Received: from localhost ([::1]:45198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqJ3B-0002r8-5d for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Dec 2020 11:56:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqJ20-00029W-10 for emacs-devel@gnu.org; Fri, 18 Dec 2020 11:55:04 -0500 Original-Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:39655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqJ1y-0000lV-9O for emacs-devel@gnu.org; Fri, 18 Dec 2020 11:55:03 -0500 Original-Received: by mail-qt1-x831.google.com with SMTP id a6so1717185qtw.6 for ; Fri, 18 Dec 2020 08:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ftfl.ca; s=google; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rvo13xqILedi+z1A8sw6FaSeOEZGCTSpbRlNSZGB53g=; b=Fs3wddtNAnLe5P7OSfbu8lh8PrYLSK0z3e2y5NZpW8wfwF6KTqm8LzHj/sZ0VA1wMl UwZHjZV7/HR0eaJxpetCiysGk0qI+TTekzvgdTtv7ebXDG71aP5hPXcYyuwWgGVLVtiL JVEiOp19dmfhmoEi0vAJ09rQZKL8CUqbiKXjg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rvo13xqILedi+z1A8sw6FaSeOEZGCTSpbRlNSZGB53g=; b=C6oByt+qwDYPJ+oVfsmq6Vt7zT+1tAtSOUFfgy6r/YyJFSv8KSogMoRpRsrJAMsJ9C eQb8DfK6iPtezIEL+9XJV/JdQhgGSMQNgtoOKkdYJsWdrSoSNt0kwzkdajbpOHECSqek vr2M0YfMxyjr12q0TVIaLX391cRRA/z4791dCs9bayOrUkvE/QaYZ3/GDaxIr5vL88Li /JoypcoZ8GAPF/M8BPI2Un6rmmXZeY7TnD79zOzzofRVv0WnUjLG68nna8XRrskAXKzs Q/I8+DlZ4fUWyXq63CREpS2cbjGLmctnACtz39TBHIQrYYnCwjA5RvsxdG182Yjtxs1p htYQ== X-Gm-Message-State: AOAM532WDYlmAazcunGO4Pr2CNfCnP0nF9PDpleoZHmWveChHnNBrO+F 7zlZ2DM/cS0KGlutK1rU2T4W4nHy+umxcA== X-Google-Smtp-Source: ABdhPJxMUX5brg2ZoU3ZOBf42+lQSbv5lw5h76CTk/UysdK0uRWeuktOE4l6SPXZU1uzaOBrEmyCkQ== X-Received: by 2002:ac8:670e:: with SMTP id e14mr4829768qtp.68.1608310500284; Fri, 18 Dec 2020 08:55:00 -0800 (PST) Original-Received: from phe.ftfl.ca.ftfl.ca (drmons0544w-142-177-84-88.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.177.84.88]) by smtp.gmail.com with ESMTPSA id f10sm5700679qtg.27.2020.12.18.08.54.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Dec 2020 08:54:59 -0800 (PST) In-Reply-To: <87tusjjwh1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 18 Dec 2020 10:26:50 +0100") Received-SPF: pass client-ip=2607:f8b0:4864:20::831; envelope-from=jrm@ftfl.ca; helo=mail-qt1-x831.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261208 Archived-At: On Fri, 2020-12-18 at 10:26, Lars Ingebrigtsen wrote: > Lars Ingebrigtsen writes: >> I'm seeing the same behaviour with -n with both existing and >> non-existing files, though. (That is, that the Emacs frame doesn't get >> focus.) It'd be nice if you could figure out when the frame still gets >> focus, because that sounds like another wrinkle... > I've now pushed a change that fixes the -n problem, I think, which > hopefully doesn't regress anything else. Unfortunately we don't have a > test suite for this stuff, I think, but I hope this doesn't break > anything else. I tested your change and it looks good here. In your other message (and before the fix) you asked about figuring out when the frame still got focus. I know that when I visited a few files that weren't written on disk, the frame still got focus. I was testing with this alias: emacsclient -a= -n If there are still issues, I could revert back and try more tests. Thank you, Joe