From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Other details about completion. Date: Mon, 04 Apr 2022 22:45:00 +0300 Organization: LINKOV.NET Message-ID: <86czhw4oqr.fsf@mail.linkov.net> References: <20220401153839.idrzrbfl2yfzga3y.ref@Ergus> <20220401153839.idrzrbfl2yfzga3y@Ergus> <86r16g92v5.fsf@mail.linkov.net> <20220401202425.jfrwqmkm3ffmcm5h@Ergus> <20220404193501.adojhz7uvvaoq4sj@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32556"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Philip Kaludercic , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 04 21:52:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbSkn-0008Ni-Lt for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Apr 2022 21:52:45 +0200 Original-Received: from localhost ([::1]:53104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbSkm-0003aq-KI for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Apr 2022 15:52:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbSjW-0001l9-7G for emacs-devel@gnu.org; Mon, 04 Apr 2022 15:51:28 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:40727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbSjK-0005Hg-6U for emacs-devel@gnu.org; Mon, 04 Apr 2022 15:51:16 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 2CEE0E0002; Mon, 4 Apr 2022 19:51:08 +0000 (UTC) In-Reply-To: <20220404193501.adojhz7uvvaoq4sj@Ergus> (Ergus's message of "Mon, 4 Apr 2022 21:35:01 +0200") Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287773 Archived-At: > May I finally add this patch to master?? I don't know, maybe Philip has no time to review your patch? > On Fri, Apr 01, 2022 at 10:24:25PM +0200, Ergus wrote: >>Hi again... >> >>Here I attached a small patch that makes 3 small changes: >> >>1) Remove the trailing newline in completions one-column >>2) Use another condition in next-completion to jump to minibuffer. >> >>Normally next-completion with tabs at the end of the buffer needs an >>extra tab because it goes to the end of the last completion before >>jumping to the minibuffer or wrap.. That extra tab is because the >>condition to jump or wrap was eobp/bobp assuming that there is not text >>unproppertized after the last candidate. >> >>3) Remove a comment in switch-to-completions. That comment suggested that >>the next-completion action must be called inside >>minibuffer-completion-help but IMO that is not totally correct when >>completion-auto-select has some of the new values. >> >>Please, if anyone could review,correct and push I would be very >>grateful.