From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 2b3f3d421a: Make minibuffer lazy highlight setup buffer-local where appropriate Date: Thu, 19 May 2022 19:20:46 +0300 Organization: LINKOV.NET Message-ID: <86czg9trgp.fsf@mail.linkov.net> References: <165264034407.21518.7194358780844409479@vcs2.savannah.gnu.org> <20220515184546.6304CC01683@vcs2.savannah.gnu.org> <87lev2h590.fsf@gmail.com> <86ee0qd5sf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26515"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Augusto Stoffel , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 19 18:35:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrj7s-0006lf-LA for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 18:35:48 +0200 Original-Received: from localhost ([::1]:50272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrj7r-0005bd-I7 for ged-emacs-devel@m.gmane-mx.org; Thu, 19 May 2022 12:35:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrj65-0003Rb-Rw for emacs-devel@gnu.org; Thu, 19 May 2022 12:33:57 -0400 Original-Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]:51477) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrj5r-000050-RW for emacs-devel@gnu.org; Thu, 19 May 2022 12:33:57 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 72505240002; Thu, 19 May 2022 16:33:36 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Wed, 18 May 2022 16:51:40 -0400") Received-SPF: pass client-ip=2001:4b98:dc4:8::221; envelope-from=juri@linkov.net; helo=relay1-d.mail.gandi.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289981 Archived-At: >>> 1. With an active region, call C-M-% >>> 2. Switch from the minibuffer back to the original buffer >>> 3. Call keyboard-escape-quit (maybe twice) to quit the minibuffer >>> prompt. >>> >>> Then the buffer-local value of `isearch-filter-predicate' is not cleaned >>> up. Is it by any chance intentional that minibuffer-exit-hook doesn't >>> run in this case? >> >> Indeed, a buffer-local minibuffer-exit-hook is not called >> when the minibuffer is exited outside of the minibuffer. > > Looks like a bug. > How 'bout the patch below? Alas, it even breaks exiting the minibuffer directly from the minibuffer. > - record_unwind_protect_void (run_exit_minibuf_hook); > + record_unwind_protect (run_exit_minibuf_hook, Fcurrent_buffer ()); After a little debugging I see that everything is fixed after replacing 'Fcurrent_buffer ()' with 'minibuffer': record_unwind_protect (run_exit_minibuf_hook, minibuffer);