From: Juri Linkov <juri@linkov.net>
To: "T.V Raman" <raman@google.com>
Cc: emacs-devel@gnu.org
Subject: Re: Observe Slowness In minibuffer-next-completion and friends
Date: Fri, 10 Nov 2023 09:49:36 +0200 [thread overview]
Message-ID: <86cywiqhlr.fsf@mail.linkov.net> (raw)
In-Reply-To: <p91wmuqntcl.fsf@google.com> (T. V. Raman's message of "Thu, 09 Nov 2023 20:08:10 -0800")
> This appears to be new as of this afternoon's update on Git:
>
> Type:
> C-h f next- <tab>
> Then press down-arrow to move to next completion; the completion list
> appears to be not active for about a second. I already tried setting
> completion-highlight-face to nil, but the slowness remains; from
> memory this feels new compared to yesterday
The first time I tried it was very slow, it took about 3 seconds.
Then on next attempts it was instantaneous. This means only one thing
that you have to wait a little until asynchronous native compilation
finishes its job.
That said, I think there are more opportunities for optimization.
What I don't like is that it checks the presence of the completions
window for the every key pressed. A possible optimization would be
to set a minibuffer-local variable when the completions window
is displayed, and unset it when the window disappears. However,
still can't handle the case when the user closes the completions
window manually with e.g. 'C-x 0'.
next prev parent reply other threads:[~2023-11-10 7:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 4:08 Observe Slowness In minibuffer-next-completion and friends T.V Raman
2023-11-10 7:38 ` Eli Zaretskii
2023-11-10 17:00 ` T.V Raman
2023-11-10 7:49 ` Juri Linkov [this message]
2023-11-10 17:01 ` T.V Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cywiqhlr.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=emacs-devel@gnu.org \
--cc=raman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).