From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Flymake Support Indicator Errors in Margin
Date: Sat, 06 Apr 2024 14:36:47 +0300
Message-ID: <86cyr23epc.fsf@gnu.org>
References: <CACnP4N+vfEc-eCd2PN-OZYf7FEuLq2pJW1_Z7jwyZPQGaoJgNA@mail.gmail.com>
 <87r0gfajlh.fsf@posteo.net>
 <CACnP4NJmmuzno0BV-TgBisj2oQEcV8ZuEJKiv_TKerQ4UchHnQ@mail.gmail.com>
 <868r2mtjdk.fsf@gnu.org>
 <CACnP4NJjzZJUOwZudFnPLys-eJnYsjJ=hvj=h9HznGNf=9r28w@mail.gmail.com>
 <86msr19ipu.fsf@gnu.org>
 <CACnP4NJgW8G6RJdu-W-fCMgGEey3eL9EErFBgMn8jd8=E9LMiw@mail.gmail.com>
 <864jd677qh.fsf@gnu.org> <87jzm0iza9.fsf@catern.com>
 <CACnP4N+R+uc6XNM=J6zj5ZHJwrLciykVWXZoZ7BGX8O3KTTwmw@mail.gmail.com>
 <87cyrsitqw.fsf@catern.com>
 <CACnP4NJzSERGdusghcvJgKndmo+ToXZ9uR3SEsy7MSwZzXfBDg@mail.gmail.com>
 <CACnP4NK571b_DVH9U8tzjBGmi9wmYHMg4eMbPUKnDz7UGoL9mw@mail.gmail.com>
 <871q7w4jn7.fsf@catern.com>
 <CACnP4N+r6aoGOjSHxJAEfT6+jY7bEWYkw7UeRx6iy-w0D+39Ag@mail.gmail.com>
 <86y1a2hp3s.fsf@gnu.org>
 <CACnP4N+q=SjnSWhvgR2NQijdhvqQ4etF8LKYoWqE52tbe7JcCQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="4778"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: sbaugh@catern.com, sbaugh@janestreet.com, philipk@posteo.net,
 emacs-devel@gnu.org, luangruo@yahoo.com
To: Elijah G <eg642616@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 06 13:37:16 2024
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1rt4MF-0000wV-I1
	for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Apr 2024 13:37:15 +0200
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1rt4Ls-0007da-24; Sat, 06 Apr 2024 07:36:52 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1rt4Lq-0007Zt-Kp
 for emacs-devel@gnu.org; Sat, 06 Apr 2024 07:36:50 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1rt4Lq-0005V5-5s; Sat, 06 Apr 2024 07:36:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=5NA6T9V7gZAPnZc6LmCPjauZ7kz+KUIxDkIfIkqmLok=; b=S/dQ6uv1uQEzOm+yYGfP
 imvW21CBEO/fPFTOJd93a7ylIYpT2SNMZEqu1cTGC+U606LU61oymveDSCWxE84Ys8itmHvvrcQ2n
 POCXqlrOcVExvOj0Zk8n6dmvjm1pQjvujW5VjnLsIyYzmIlbCpfNAf9lbRahTfivlGedJXg16mq8B
 1t611P4d3zK3aTrnXtEPhVsx7xDyGFt0Yyw/rX0kQjdTX+CSkPOVkLhn3RBV+0XDpwNkmcDEE1+PS
 kywUT9Hc2Jy5/mjKnlq6Rf/i8G0O7G52PUn0pD11lTSmz8X7N9pfMqZuRFiW0RHs4dAQ6HPa59pzb
 RP7UjbBJxDwHuw==;
In-Reply-To: <CACnP4N+q=SjnSWhvgR2NQijdhvqQ4etF8LKYoWqE52tbe7JcCQ@mail.gmail.com>
 (message from Elijah G on Thu, 28 Mar 2024 11:34:23 -0600)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:317569
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/317569>

> From: Elijah G <eg642616@gmail.com>
> Date: Thu, 28 Mar 2024 11:34:23 -0600
> Cc: sbaugh@catern.com, sbaugh@janestreet.com, philipk@posteo.net, 
> 	emacs-devel@gnu.org, luangruo@yahoo.com
> 
> On Thu, Mar 28, 2024 at 12:01 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > > Sadly I couldn't find anything for detecting HDiPI frames, so the user
> > > must have to configure it.
> >
> > Can you explain the problem, and point me to the code which has to
> > deal with it?
> 
> Sure, in this part of the code.
> 
> > +(defcustom flymake-indicator-type (if (display-graphic-p)
> > +                                      'fringes
> > +                                    'margins)
> > +  "Indicate which indicator type to use for display errors.
> 
> I wanted to check if the frame is in HiDPI to
> automatically set to margins because fringes are so small in those screens.

As I wrote up-thread, I don't think we should adapt to HiDPI in this
respect.