unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: mattias.engdegard@gmail.com
Cc: luangruo@yahoo.com, emacs-devel@gnu.org
Subject: Re: missing lexical-binding cookie warning when loading .el files
Date: Sat, 04 May 2024 12:24:07 +0300	[thread overview]
Message-ID: <86cyq2gcaw.fsf@gnu.org> (raw)
In-Reply-To: <86edaigd6n.fsf@gnu.org> (message from Eli Zaretskii on Sat, 04 May 2024 12:05:04 +0300)

> Date: Sat, 04 May 2024 12:05:04 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: mattias.engdegard@gmail.com, emacs-devel@gnu.org
> 
> > From: Po Lu <luangruo@yahoo.com>
> > Cc: mattias.engdegard@gmail.com,  emacs-devel@gnu.org
> > Date: Sat, 04 May 2024 16:23:09 +0800
> > 
> > Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > > Those are under user-emacs-directory, right?
> > 
> > Correct.  My point was that presumably the warning is appropriate for at
> > least the early-init file, and possibly also for the init file, when it
> > is not generated by such mechanisms as Custom.
> 
> I disagree.  I think we shouldn't bug users due to their init files,
> not at all.
> 
> So I think at this point we could either (a) exempt all files below
> user-emacs-directory, (b) add a database of basenames of files that
> should be exempt from these warnings, or (c) a combination of those
> two.
> 
> Any other suggestions?

I see Mattias already installed something, without waiting for the
discussion to come to conclusions.

But IMO the installed change is incorrect/incomplete:

  . it hard-codes ".emacs" as the file for which we don't warn, thus
    leaving the warning in effect for early-init files
  . the init file can be named init.el or _emacs (with or without
    .el), and the change doesn't handle that
  . there are files like recentf-save-file (default: ".recentf") or
    abbrev-file-name (default: "abbrev_defs") and others, which should
    also be exempt of this

I wish people would discuss such changes before committing them.  This
is a complex issue, with many aspects that are not really obvious, as
Emacs loads files in many contexts and for many different purposes.
We should be sure we understand all the aspects before we design and
implement solutions.



  parent reply	other threads:[~2024-05-04  9:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03 17:28 missing lexical-binding cookie warning when loading .el files Mattias Engdegård
2024-05-03 17:59 ` Eli Zaretskii
2024-05-03 19:41   ` Mattias Engdegård
2024-05-04  3:41     ` Po Lu
2024-05-04  4:18       ` Po Lu
2024-05-04  4:40         ` Po Lu
2024-05-04  7:32           ` Eli Zaretskii
2024-05-04  8:10             ` Po Lu
2024-05-04  8:19               ` Eli Zaretskii
2024-05-04  8:23                 ` Po Lu
2024-05-04  9:05                   ` Eli Zaretskii
2024-05-04  9:22                     ` Po Lu
2024-05-04  9:24                     ` Eli Zaretskii [this message]
2024-05-04 10:31                       ` Mattias Engdegård
2024-05-04 12:59                         ` Eli Zaretskii
2024-05-04 16:22                           ` Mattias Engdegård
2024-05-05 14:13                             ` Mattias Engdegård
2024-05-05 14:28                               ` Arsen Arsenović
2024-05-05 14:58                                 ` Mattias Engdegård
2024-05-05 16:22                                   ` [External] : " Drew Adams
2024-05-05 14:44                               ` Po Lu
2024-05-04  9:47             ` Mattias Engdegård
2024-05-04 10:01               ` Po Lu
2024-05-04 16:54               ` [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86cyq2gcaw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=mattias.engdegard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).