Re: MPS: Forwording symbols

[Eli Zaretskii <eliz@gnu.org>]

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: Emacs Devel <emacs-devel@gnu.org>,  Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 17 Jun 2024 22:07:03 +0200
> 
> Helmut Eller <eller.helmut@gmail.com> writes:
> 
> > On Mon, Jun 17 2024, Gerd Möllmann wrote:
> >
> >> I still get the same assertion because client is not pdumper_object_p.
> >> Could it be that we have to use pdumper_cold_object_p? I'll
> >> give it a try. Strangely, I can't call that function in LLDB... :-(
> >
> > dump_cold_buffer uses a dirty trick to get that damn
> > IGC_OBJ_DUMPED_BUFFER_TEXT header written out.  igc_dump_finish_obj
> > could just check the type.  That's something for tomorrow.  Now it's too
> > late.
> 
> Ok. I'll push something that lets me build, and with an optimized build
> I get
> 
> .../emacs/savannah/igc % /usr/bin/time src/emacs -batch -f igc--collect
>         0.18 real         0.09 user         0.08 sys
> 
> Not too bad :-). Good night!

The latest HEAD builds here with one harmless warning:

  pdumper.c:4776:1: warning: 'dump_map_file_w32' defined but not used [-Wunused-function]
   4776 | dump_map_file_w32 (void *base, int fd, off_t offset, size_t size,
	| ^~~~~~~~~~~~~~~~~
  pdumper.c:4639:1: warning: 'dump_anonymous_allocate_w32' defined but not used [-Wunused-function]
   4639 | dump_anonymous_allocate_w32 (void *base,
	| ^~~~~~~~~~~~~~~~~~~~~~~~~~~

and still infloops(?), hitting SIGSEGV repeatedly here:

  Thread 1 received signal SIGSEGV, Segmentation fault.
  igc_on_pdump_loaded (dump_base=dump_base@entry=0xb000008,
      hot_start=hot_start@entry=0xb000080, hot_end=0xb585408,
      cold_start=0xb5b0008, cold_end=cold_end@entry=0xba8b6a8,
      cold_user_data_start=0xb7038a8, heap_end=0xb707af8) at igc.c:3763
  3763      eassert (((struct igc_header *)cold_start)->obj_type
  (gdb) p cold_start
  $1 = (void *) 0xb5b0008
  (gdb) p ((struct igc_header *)cold_start)->obj_type
  Cannot access memory at address 0xb5b0008

Any ideas are welcome.  I will gladly provide more information if
needed.

Thanks.