From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc 90e80a9a53e 6/6: Adjust igc.c code to header changes Date: Sun, 21 Jul 2024 19:27:18 +0300 Message-ID: <86cyn6bti1.fsf@gnu.org> References: <8634o3c98h.fsf@gnu.org> <861q3nc5j7.fsf@gnu.org> <86zfqabz5c.fsf@gnu.org> <5p8jkXALtW4p4ny5SDaTELHeMcDhmaymtiNVusLIQJBqUE9Vpsbyp4Bg_bc19PgWGxP5U3iBgVDnZeYptqz4BrBTcuZgmSwVq_PMiY1Evzg=@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28023"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 21 18:27:55 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sVZPe-00077z-Kg for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jul 2024 18:27:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVZPB-00025z-2O; Sun, 21 Jul 2024 12:27:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVZP7-00022u-TU for emacs-devel@gnu.org; Sun, 21 Jul 2024 12:27:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVZP7-0003BJ-Av; Sun, 21 Jul 2024 12:27:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4Cpd/buRi0Ejn+0IVVKc/yjfbq5ZKhOpDH0DfzLi2cA=; b=SoYQzeXB5JLy 07Sr4qQV0BGRugNQUS3jARcAFTYKQ7ue8DHcMm9I5N5SQVaBzBtI7CIjsSqsCLrG41T33wJerZ9KJ xLzwxb/bLwxc+M8Wbc6Q2mRHEdg5PN/D+n4CvExLVia5rwfbNr71Ml5rQgGA5zKGXSReiDrn/5r6w FR8uIfRxFHxmMrLp7MgEtC1Focmi9SRsRJvlshEBzKznDbKm9Ui4TTJ+h7xhiIeTMXK5gD6ZBw6lM NHDYM49UdGKMoFsBOm4xHIECKkSxqzA0jYd7kZjF/WMHc64ABCzbNh7C19pxOfoyJDXyoIKqcW12F 6XaP40BygEuPbk03kjvYng==; In-Reply-To: <5p8jkXALtW4p4ny5SDaTELHeMcDhmaymtiNVusLIQJBqUE9Vpsbyp4Bg_bc19PgWGxP5U3iBgVDnZeYptqz4BrBTcuZgmSwVq_PMiY1Evzg=@protonmail.com> (message from Pip Cet on Sun, 21 Jul 2024 16:20:57 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321908 Archived-At: > Date: Sun, 21 Jul 2024 16:20:57 +0000 > From: Pip Cet > Cc: emacs-devel@gnu.org > > > Why cannot you identify this kind of object during dumping, and avoid > > applying whatever igc_dump_finish_obj does? > > You mean you'd prefer to leave the pseudovector header for builtin subrs at its current value? We can do that, but I think the MPS header should still be valid. (It's not with the patch I had attached: that makes it claim an object size of 112 bytes when it's actually just 96 bytes, and that causes us to overwrite the first 16 bytes after the last subr; in my case, stdout... Anyway, next patch attached, which duplicates a bit of code unnecessarily.) Then why doesn't your patch do that? And this new patch is even more massive than the previous one? In any case, if we need to change the definition of Aligned_Lisp_Subr, let's do that only "#if HAVE_MPS", and leave the old code intact.