From: Eli Zaretskii <eliz@gnu.org>
To: Pip Cet <pipcet@protonmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: scratch/igc 90e80a9a53e 6/6: Adjust igc.c code to header changes
Date: Sun, 21 Jul 2024 19:27:18 +0300 [thread overview]
Message-ID: <86cyn6bti1.fsf@gnu.org> (raw)
In-Reply-To: <5p8jkXALtW4p4ny5SDaTELHeMcDhmaymtiNVusLIQJBqUE9Vpsbyp4Bg_bc19PgWGxP5U3iBgVDnZeYptqz4BrBTcuZgmSwVq_PMiY1Evzg=@protonmail.com> (message from Pip Cet on Sun, 21 Jul 2024 16:20:57 +0000)
> Date: Sun, 21 Jul 2024 16:20:57 +0000
> From: Pip Cet <pipcet@protonmail.com>
> Cc: emacs-devel@gnu.org
>
> > Why cannot you identify this kind of object during dumping, and avoid
> > applying whatever igc_dump_finish_obj does?
>
> You mean you'd prefer to leave the pseudovector header for builtin subrs at its current value? We can do that, but I think the MPS header should still be valid. (It's not with the patch I had attached: that makes it claim an object size of 112 bytes when it's actually just 96 bytes, and that causes us to overwrite the first 16 bytes after the last subr; in my case, stdout... Anyway, next patch attached, which duplicates a bit of code unnecessarily.)
Then why doesn't your patch do that? And this new patch is even more
massive than the previous one?
In any case, if we need to change the definition of Aligned_Lisp_Subr,
let's do that only "#if HAVE_MPS", and leave the old code intact.
next prev parent reply other threads:[~2024-07-21 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 10:47 scratch/igc 90e80a9a53e 6/6: Adjust igc.c code to header changes Eli Zaretskii
2024-07-21 11:42 ` Pip Cet
2024-07-21 12:07 ` Eli Zaretskii
2024-07-21 14:11 ` Pip Cet
2024-07-21 14:25 ` Eli Zaretskii
2024-07-21 16:20 ` Pip Cet
2024-07-21 16:27 ` Eli Zaretskii [this message]
2024-07-22 14:35 ` Pip Cet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cyn6bti1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=pipcet@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).