unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Joe Wells <jbw@macs.hw.ac.uk>
To: rms@gnu.org
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Fwd: overlay face property not used for after-string 	property
Date: Sat, 03 Nov 2007 16:03:14 +0000	[thread overview]
Message-ID: <86bqabjozh.fsf@macs.hw.ac.uk> (raw)
In-Reply-To: <E1IoA9g-0001Si-2q@fencepost.gnu.org> (Richard Stallman's message of "Fri\, 02 Nov 2007 23\:58\:40 -0400")

Richard Stallman <rms@gnu.org> writes:

>     > The fix we are discussing will get rid of this problem, right?
>
>     No, the problem with the before-string/display/after-string
>     properties being affected by a face from the buffer appears to
>     be a completely unrelated issue which will need to be debugged
>     separately.
>
> I see.  We have one problem with overlay properties, and
> another with text properties.
>
> I think I just fixed the most of the problem for overlay
> properties.  Now overlay before-strings and after-strings should be
> unaffected by the face properties of all overlays.  They are,
> however, affected by `face' text properties and by region
> highlighting.
>
> It is not 100% clear that that is correct; you might want a longer
> overlay's `face' property, or a higher priority overlay's `face'
> property, to affect the before-strings and after-strings of smaller
> overlays.

This is a very good point!

> That seems like somewhat of a can of worms.  The rule I implemented
> is simple and clear.
>
> Do you agree?

I agree that it is simple and clear.  However, given the point you
made above, I think it would be better if before-string and
after-string properties were affected by the face property of other
overlays (regardless of whether they should be affected by the face
property of the same overlay).

> And do you get good results from the fix?  (It is in Emacs 22.)

I will not be able to test in a new Emacs version in the near future.

> Do you think the same rule is right for display property strings that
> come from overlays?  That is, obey `face' text properties, but not
> `face' overlay properties?

No.

> Once we are sure what is right for overlay properties, I will start
> dealing with the text property effects.

By the way, the concern I raise in the message you quote above is not
about text properties in the before-string or after-string, but about
text properties in the buffer.

-- 
Joe

  reply	other threads:[~2007-11-03 16:03 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-22  9:00 [jbw@macs.hw.ac.uk: overlay face property not used for after-string property] Richard Stallman
2007-10-22 15:44 ` Fwd: overlay face property not used for after-string property Stefan Monnier
2007-10-24  9:49   ` Joe Wells
     [not found]   ` <E1Im8Y2-0000zW-Tn@fencepost.gnu.org>
2007-10-28 15:06     ` Joe Wells
2007-10-28 15:21       ` Johan Bockgård
2007-10-29  9:22       ` Richard Stallman
2007-10-29  9:57         ` Joe Wells
2007-11-03  3:58           ` Richard Stallman
2007-11-03 16:03             ` Joe Wells [this message]
2007-11-04 19:56               ` Richard Stallman
2007-11-04 23:03                 ` Joe Wells
2007-11-05  8:47                   ` Richard Stallman
2007-11-05  9:30                     ` David Kastrup
2007-11-05 11:51                       ` Joe Wells
2007-11-05 12:05                         ` Joe Wells
2007-11-06  2:16                           ` Richard Stallman
2007-11-06  3:30                             ` Joe Wells
2007-11-06  8:30                               ` Stefan Monnier
2007-11-06  9:18                                 ` David Kastrup
2007-11-06 10:05                                   ` Stefan Monnier
2007-11-07  0:15                                 ` Richard Stallman
2007-11-07  0:15                               ` Richard Stallman
2007-11-06  2:15                         ` Richard Stallman
2007-11-06  3:19                           ` Joe Wells
2007-11-05 14:55                       ` Stefan Monnier
2007-11-05 15:04                         ` David Kastrup
2007-11-05 16:35                           ` Joe Wells
2007-11-05 16:53                             ` David Kastrup
2007-11-05 22:06                               ` Joe Wells
2007-11-05 16:29                         ` Joe Wells
2007-11-05 19:38                           ` Stefan Monnier
2007-11-05 21:59                             ` Joe Wells
2007-11-06  8:37                               ` Richard Stallman
2007-11-06  2:16                         ` Richard Stallman
2007-11-05 11:55                     ` Joe Wells
2007-11-06  2:16                       ` Richard Stallman
2007-11-04 19:56               ` Richard Stallman
2007-11-04 23:10                 ` Joe Wells
2007-11-03 19:21             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bqabjozh.fsf@macs.hw.ac.uk \
    --to=jbw@macs.hw.ac.uk \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).