From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: emacs.c broken by revision 1.435 Date: Wed, 23 Jul 2008 10:48:23 +0200 Message-ID: <86bq0pf0ko.fsf@lola.quinscape.zz> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1216802952 16960 80.91.229.12 (23 Jul 2008 08:49:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Jul 2008 08:49:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Tim Van Holder" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 23 10:50:01 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KLa2n-0004FS-66 for ged-emacs-devel@m.gmane.org; Wed, 23 Jul 2008 10:49:57 +0200 Original-Received: from localhost ([127.0.0.1]:60511 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLa1t-0002x7-QB for ged-emacs-devel@m.gmane.org; Wed, 23 Jul 2008 04:49:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLa1M-0002lG-Gd for emacs-devel@gnu.org; Wed, 23 Jul 2008 04:48:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLa1L-0002kT-2E for emacs-devel@gnu.org; Wed, 23 Jul 2008 04:48:27 -0400 Original-Received: from [199.232.76.173] (port=46989 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLa1K-0002kL-Tz for emacs-devel@gnu.org; Wed, 23 Jul 2008 04:48:26 -0400 Original-Received: from mail.quinscape.de ([212.29.44.217]:34497) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KLa1K-00005T-Dk for emacs-devel@gnu.org; Wed, 23 Jul 2008 04:48:26 -0400 Original-Received: (qmail-ldap/ctrl 23291 invoked from network); 23 Jul 2008 08:48:24 -0000 Original-Received: from unknown (HELO lola.quinscape.zz) ([10.0.3.43]) (envelope-sender ) by quinx.quinscape.de (qmail-ldap-1.03) with SMTP for ; 23 Jul 2008 08:48:24 -0000 Original-Received: by lola.quinscape.zz (Postfix, from userid 1001) id 5A68E8F046; Wed, 23 Jul 2008 10:48:23 +0200 (CEST) In-Reply-To: (Tim Van Holder's message of "Wed, 23 Jul 2008 09:24:54 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-AntiVirus: checked by AntiVir MailGate (version: 2.1.3-2; AVE: 7.8.1.11; VDF: 7.0.5.155; host: quinx) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101293 Archived-At: "Tim Van Holder" writes: > The "LINUX_SBRK_BUG" condition was incorrectly replaced with > > #if (GNU_LINUX) && __GNU_LIBRARY__ - 0 < 6 > __sbrk (1); > #endif > > instead of > > #if defined (GNU_LINUX) && __GNU_LIBRARY__ - 0 < 6 > __sbrk (1); > #endif > > resulting in a broken build. Can we rely on "defined" being available? Seems like an ANSI feature to me... Maybe nested #ifdef and #if would be safer? -- David Kastrup