From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Akira Kyle Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Interferences between xwidgets and async processes? Date: Sat, 14 Nov 2020 12:53:13 -0700 Message-ID: <86blfzu34m.fsf@akirakyle.com> References: <87mu06wyfb.fsf@gnus.org> <83tuuecrl5.fsf@gnu.org> <83v9etaz6z.fsf@gnu.org> <86sg9nsg5a.fsf@akirakyle.com> <87pn4mmybt.fsf@gnus.org> <86h7putm1q.fsf@akirakyle.com> <87sg9cymdw.fsf@gnus.org> <83blfzvrh0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11821"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.13; emacs 28.0.50 Cc: sdycjsj@gmail.com, Lars Ingebrigtsen , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 14 20:54:28 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ke1cw-0002wu-PL for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Nov 2020 20:54:26 +0100 Original-Received: from localhost ([::1]:33054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ke1cv-0000Od-Qw for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Nov 2020 14:54:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke1bq-0007yC-AU for emacs-devel@gnu.org; Sat, 14 Nov 2020 14:53:18 -0500 Original-Received: from mail-ot1-f68.google.com ([209.85.210.68]:42148) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ke1bo-00053U-Ky; Sat, 14 Nov 2020 14:53:17 -0500 Original-Received: by mail-ot1-f68.google.com with SMTP id h16so7982016otq.9; Sat, 14 Nov 2020 11:53:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=RV5+cqF7PyMskKnqkTWhFFZfQaUloTGHEGzr1nLYrnc=; b=nbt5WHEwC4WgAyxx0aAn/jGykhReU8VVZ1ZcjilH+HqBGbs5E68Af94TUYr/KZMYiZ gUkjwvyc48V3XLp1bUsG4gMkr6jviTwXY4gh1g6Ld/V/eOCv2YjV+hirT42D3GZyg+I3 WjTEgjUWfcRm21/3MB4LquLWa6FIt70tlKW+8+TQGnNoOOwuC1Ep2GX5mMidOWJmq+Sy Hw8AmMOa8ljhFrr+tyedMgeHRzUjNtTRbD6qFl1Ap0LiPudW4MjwsvjzmaC3Fx6y1JiF 2cmYHUOJtxu7niGQV90UMXx4Qi8BghxQ5kq3y/zMM6bVeRXpEOvKsnWZY4eVtVKw3udf 9L9w== X-Gm-Message-State: AOAM532qhSLEEeni/tS4/tqXCW9DJdEgVx4m9a9yqV+Z0CEJh79FX2X8 IdUQ6/tYpnX4st7tD5OdEJpx5MDghX38xTGz X-Google-Smtp-Source: ABdhPJzh9FGuJecYqoZ7d1Wjn9U9tgvVLXnOnq6NZVTuhItMOrEwFzt+9dF7kPc4jH5+14ueheTIJg== X-Received: by 2002:a05:6830:1319:: with SMTP id p25mr5924819otq.33.1605383595184; Sat, 14 Nov 2020 11:53:15 -0800 (PST) Original-Received: from data (c-67-162-131-131.hsd1.co.comcast.net. [67.162.131.131]) by smtp.gmail.com with ESMTPSA id l89sm2826571otc.6.2020.11.14.11.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2020 11:53:14 -0800 (PST) In-reply-to: <83blfzvrh0.fsf@gnu.org> Received-SPF: pass client-ip=209.85.210.68; envelope-from=aikokyle@gmail.com; helo=mail-ot1-f68.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/14 14:53:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259182 Archived-At: On Sat, Nov 14, 2020 at 09:22 AM, Eli Zaretskii wrote: >> > The attached patch fixes this but only in a temporary way. >> >> Thanks; applied to Emacs 28. > > Just to be sure: the fix that is now installed on master does > support > current and old versions of Glib, where the old code seemed to > work? > Or does it break with older Glib versions? I didn't explicitly try it with glib versions before they changed the signal handling in commit 2e471acf, but it *should* work with versions before the change. As you can see in the patch, it essentially just makes Emacs more aggressive in taking over the signal handler and in glib versions before 2e471acf, g_source_unref (source) wouldn't result in glib resetting the signal handler to SIG_DFL, in which case Emacs will just install itself twice to handle SIGCHLD which is fine. I think commit 2e471acf got added to glib with version 2.37.5 which was released over 7 years ago.