From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Duplicated outline-cycle binding, and problems with the new one Date: Mon, 10 Jan 2022 20:30:51 +0200 Organization: LINKOV.NET Message-ID: <86bl0jjvdw.fsf@mail.linkov.net> References: <9DFDAD07-DBC0-4FAE-A565-D1EE6045E7D8@gmail.com> <86ilv25714.fsf@mail.linkov.net> <86pmp6cohf.fsf@mail.linkov.net> <86a6g87lu5.fsf@mail.linkov.net> <86pmp0ovak.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3422"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Monnier , Emacs developers To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 10 19:33:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6zTe-0000fA-BU for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Jan 2022 19:33:06 +0100 Original-Received: from localhost ([::1]:51256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6zTd-00022H-E4 for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Jan 2022 13:33:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6zRv-0007sX-LY for emacs-devel@gnu.org; Mon, 10 Jan 2022 13:31:28 -0500 Original-Received: from [2001:4b98:dc4:8::226] (port=42193 helo=relay6-d.mail.gandi.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6zRo-0005E6-Km for emacs-devel@gnu.org; Mon, 10 Jan 2022 13:31:16 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id C4399C0009; Mon, 10 Jan 2022 18:31:06 +0000 (UTC) In-Reply-To: <86pmp0ovak.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 10 Jan 2022 10:21:39 +0200") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4b98:dc4:8::226 (failed) Received-SPF: pass client-ip=2001:4b98:dc4:8::226; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284545 Archived-At: >> Once again, LGTM :-) > > Testing shows that it requires more changes in other modes, > e.g. a change is needed in diff.el to make read-only > only after calling diff-mode that adds read-only-mode-hook: I pushed a simpler fix. Thanks for the suggestion.