From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers Date: Wed, 04 May 2022 22:27:43 +0300 Organization: LINKOV.NET Message-ID: <86bkwdjeeg.fsf@mail.linkov.net> References: <87k0b84tfr.fsf@occasionallycogent.com> <87h76c4ruf.fsf@occasionallycogent.com> <86sfpwwerz.fsf@mail.linkov.net> <87czh03xa9.fsf@occasionallycogent.com> <87o80i3frf.fsf@occasionallycogent.com> <87ee1e374d.fsf@occasionallycogent.com> <861qxdf7pl.fsf@mail.linkov.net> <87wnf40x29.fsf@occasionallycogent.com> <86wnf3oi4e.fsf@mail.linkov.net> <87pmkt1owo.fsf@occasionallycogent.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16349"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Monnier , emacs-devel@gnu.org To: James N. V. Cash Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 04 21:34:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmKlu-00043w-3U for ged-emacs-devel@m.gmane-mx.org; Wed, 04 May 2022 21:34:50 +0200 Original-Received: from localhost ([::1]:34208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmKls-0006gn-M3 for ged-emacs-devel@m.gmane-mx.org; Wed, 04 May 2022 15:34:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmKkw-0005cV-IN for emacs-devel@gnu.org; Wed, 04 May 2022 15:33:50 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:34565) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmKku-0007Tc-Qr for emacs-devel@gnu.org; Wed, 04 May 2022 15:33:50 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 0955E1BF206; Wed, 4 May 2022 19:33:43 +0000 (UTC) In-Reply-To: <87pmkt1owo.fsf@occasionallycogent.com> (James N. V. Cash's message of "Wed, 04 May 2022 08:08:07 -0400") Received-SPF: pass client-ip=217.70.183.201; envelope-from=juri@linkov.net; helo=relay8-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289204 Archived-At: >>> The other approach, which the below patch implements, is try to find the >>> bounds based on the strings, but if the contents been edited, find the >>> nearest CRM separator. This is kind of nice in that it lets you edit >>> other selections but then still select a candidate, but I don't know how >>> useful/expected that really is. The logic could also be made somewhat >>> more complex (count the number of separators in `start` and `end`, try >>> to guess how many we should skip over in each direction) but I don't >>> know if that's really worthwhile. >> >> I tried out this approach and it works nicely, except the case >> when the CRM separator gets deleted by the user. But OTOH, >> the user might want to delete the separator intentionally, >> to reduce the number of selections. So it seems there is no need >> to make the logic more complex. > > Should I make a new thread with this patch then, or is the one here okay? If you think your latest patch is safe enough to install and you signed a copyright assignment for your changes, I could push it without the need to create a bug report.