From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: Renaming eglot -- or at least add an alias? Date: Thu, 13 Oct 2022 03:20:13 -0700 Message-ID: <86bkqgdnz6.fsf@stephe-leake.org> References: <86tu4lsnqk.fsf@gmail.com> <8335c0p2fn.fsf@gnu.org> <83leproov6.fsf@gnu.org> <83fsfzonwn.fsf@gnu.org> <5a1e604c-4500-a476-da3d-259d9057a7f0@yandex.ru> <838rlromxu.fsf@gnu.org> <83h70dk3wf.fsf@gnu.org> <835ygqg1bh.fsf@gnu.org> <87ilkqbsp3.fsf@thornhill.no> <0ef04e1e-3f6c-31b6-4852-0c9c2c43b912@yandex.ru> <86h708ft1k.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31627"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (windows-nt) Cc: Richard Stallman , Dmitry Gutov , eliz@gnu.org, emacs-devel@gnu.org To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 13 13:00:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oivwW-00082X-L6 for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Oct 2022 13:00:01 +0200 Original-Received: from localhost ([::1]:36934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oivwV-00041o-GS for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Oct 2022 06:59:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oivKM-0002Z8-S0 for emacs-devel@gnu.org; Thu, 13 Oct 2022 06:20:35 -0400 Original-Received: from gproxy1-pub.mail.unifiedlayer.com ([69.89.25.95]:55876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oivKJ-0005WT-GD for emacs-devel@gnu.org; Thu, 13 Oct 2022 06:20:34 -0400 Original-Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id D964D10046B66 for ; Thu, 13 Oct 2022 10:20:17 +0000 (UTC) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with ESMTP id ivK5oaNMw2FNCivK5oc3UY; Thu, 13 Oct 2022 10:20:17 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=E+cIGYRl c=1 sm=1 tr=0 ts=6347e661 a=dWLzHQi6WpdymmZIwiVdBw==:117 a=Fln8i1WyhtedwaIJAdHvmw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=vvvmwbhNdt4A:10:endurance_base64_authed_username_1 a=9i_RQKNPAAAA:8 a=mDV3o1hIAAAA:8 a=Sey3uyT79PNUB02QK0sA:9 a=Ev4oQ7kfJBNsvnoXShoW:22 a=_FVE-zBwftR9WsbkzFJk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kBOXHqsFIjtUHjt5bzzkj1/1Ij4zQelAw7Yz9GL0HhM=; b=EZLNZfsDKqNMVX0f0w62+BHko/ kGA6KxSm1MsUF1s8/7DT2Yq0CohDq/OZ5LRe4YUI4Nmjgq1GYRb36BFAwaPNNCyXAMV869f/nE0w5 x2bQu2DMIiHQDvaKx3zri3uZfXmWrfdSIdQIuctLNKIUI+81riu1vYTfJIg1a/tjAHXUIXPjDuQmC fvAktHJmwlY7fyNcllqdXbNzJPpti+9OHOUEoED3ikDGSai6xfAbxa+hlUAC/2j4RSHkGCmnVcvhW bmMlZILofAAyFebpK9WIwPnBV8UmKYpiKvAkNtXsDw7BqbFvQFNM9JDOdsygWJW9pfhE5em9pFJBI VTLvqMuw==; Original-Received: from 135-180-197-170.fiber.dynamic.sonic.net ([135.180.197.170]:53089 helo=DESKTOP-G20DCG1) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oivK5-000Lo3-B7; Thu, 13 Oct 2022 04:20:17 -0600 In-Reply-To: (Theodor Thornhill's message of "Thu, 13 Oct 2022 08:59:04 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 135.180.197.170 X-Source-L: No X-Exim-ID: 1oivK5-000Lo3-B7 X-Source-Sender: 135-180-197-170.fiber.dynamic.sonic.net (DESKTOP-G20DCG1) [135.180.197.170]:53089 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 10 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: pass client-ip=69.89.25.95; envelope-from=stephen_leake@stephe-leake.org; helo=gproxy1-pub.mail.unifiedlayer.com X-Spam_score_int: 16 X-Spam_score: 1.6 X-Spam_bar: + X-Spam_report: (1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297672 Archived-At: Theodor Thornhill writes: > On 13 October 2022 02:47:51 CEST, Stephen Leake wrote: >>Richard Stallman writes: >> >>> [[[ To any NSA and FBI agents reading my email: please consider ]]] >>> [[[ whether defending the US Constitution against all enemies, ]]] >>> [[[ foreign or domestic, requires you to follow Snowden's example. ]]] >>> >>> > > Because all of the interaction between server and client in lsp is json >>> > > there's a huge overhead with parsing and shipping things into the emacs >>> > > user interface. So IMO what tree-sitter is good at should be left to >>> > > tree-sitter. >> >>Premature optimization. >> > > Why do you say that? Because it gives a supposed cause without evidence of an actual problem. > I've been using lsp for a long time, and typing lag can get unbearable > with servers that sends too much stuff. When 20k completions > containing _full_ documentation for every result that json gets > humongous. Ok, that's actual data. On the other hand, did you measure different parts of the process, so you are sure that the json is the bottleneck, and not something else? It's not clear just from this description that a tree-sitter implementation would be faster. In addition, LSP supports sending the documentation later, after the user has actually looked at a completion item, using a completionItem/resolve request. So this sounds like a specific client or server implementation problem more than an inherent LSP problem. > Adding syntax highlights on top of that isn't advisable, considering > emacs nonmultithreaded nature. Syntax highlighting, mediated by font-lock, should only ever send small amounts of data; one screen full at a time. That is if the server supports the textDocument/semanticTokens/range request, and not just the textDocument/semanticTokens/full request. -- -- Stephe