From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: VC commit missing ChangeLog message Date: Wed, 12 Nov 2008 15:47:49 -0600 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <86abc4fwfu.fsf@lifelogs.com> References: <86ej1il3z7.fsf@lifelogs.com> <1226414985.525611.2969.nullmailer@null> <8663mukybp.fsf@lifelogs.com> <200811111658.mABGwYR1004191@mothra.ics.uci.edu> <86myg6hycx.fsf@lifelogs.com> <200811111945.mABJjWvA004946@mothra.ics.uci.edu> <86od0mgcz5.fsf@lifelogs.com> <200811120111.mAC1B6h1005596@mothra.ics.uci.edu> <86tzacg8yc.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1226527183 4496 80.91.229.12 (12 Nov 2008 21:59:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Nov 2008 21:59:43 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 12 23:00:45 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L0NlC-0000ps-Cn for ged-emacs-devel@m.gmane.org; Wed, 12 Nov 2008 23:00:26 +0100 Original-Received: from localhost ([127.0.0.1]:59486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0Nk1-0004uQ-Cb for ged-emacs-devel@m.gmane.org; Wed, 12 Nov 2008 16:59:13 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0NZC-0000Ea-3D for emacs-devel@gnu.org; Wed, 12 Nov 2008 16:48:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0NZA-0000Dm-BC for emacs-devel@gnu.org; Wed, 12 Nov 2008 16:48:01 -0500 Original-Received: from [199.232.76.173] (port=36060 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0NZA-0000Df-3e for emacs-devel@gnu.org; Wed, 12 Nov 2008 16:48:00 -0500 Original-Received: from main.gmane.org ([80.91.229.2]:43628 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L0NZ9-0001d9-Kq for emacs-devel@gnu.org; Wed, 12 Nov 2008 16:47:59 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1L0NZ5-0008Bz-Me for emacs-devel@gnu.org; Wed, 12 Nov 2008 21:47:55 +0000 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Nov 2008 21:47:55 +0000 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Nov 2008 21:47:55 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 18 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:RBgnot6EzLteg9a17lZ4R5L2vTA= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105619 Archived-At: On Wed, 12 Nov 2008 14:42:30 -0500 Stefan Monnier wrote: >> I see your point and agree. How about this patch to just call >> log-edit-insert-changelog? I call it regardless of the SETUP parameter, >> but it could follow the erase-buffer call instead. SM> I'd rather just change the default value of the hook, so that users can SM> remove that entry from the hook if they don't want it run. Wait, the hook already calls it. For me it doesn't work, though (which is why I started this thread). Something is breaking in the changelog entry detection logic. It worked when I did C-c C-a (without C-u) manually. It must have been the logic that applies C-u if C-c C-a is called twice in a row; I must have hit the key twice without realizing it. So the problem is actually that the default logic doesn't detect my ChangeLog entry, not that log-edit-insert-changelog is not called. Argh. Ted