From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Generalize start-process with keyword args Date: Mon, 16 Mar 2015 19:12:45 +0000 Message-ID: <86a8zc21ua.fsf@gmail.com> References: <87d24d3uwz.fsf-ueno@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426533207 18323 80.91.229.3 (16 Mar 2015 19:13:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Mar 2015 19:13:27 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 16 20:13:13 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YXaRp-00017k-6B for ged-emacs-devel@m.gmane.org; Mon, 16 Mar 2015 20:13:09 +0100 Original-Received: from localhost ([::1]:51233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXaRo-0006ja-F9 for ged-emacs-devel@m.gmane.org; Mon, 16 Mar 2015 15:13:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXaRk-0006h7-4u for emacs-devel@gnu.org; Mon, 16 Mar 2015 15:13:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXaRg-0001e4-VS for emacs-devel@gnu.org; Mon, 16 Mar 2015 15:13:04 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:50023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXaRg-0001d9-Pi for emacs-devel@gnu.org; Mon, 16 Mar 2015 15:13:00 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YXaRc-0000yT-6G for emacs-devel@gnu.org; Mon, 16 Mar 2015 20:12:56 +0100 Original-Received: from 82-69-64-228.dsl.in-addr.zen.co.uk ([82.69.64.228]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 16 Mar 2015 20:12:56 +0100 Original-Received: from andrewjmoreton by 82-69-64-228.dsl.in-addr.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 16 Mar 2015 20:12:56 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 30 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 82-69-64-228.dsl.in-addr.zen.co.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (windows-nt) Cancel-Lock: sha1:hc6AnMmQCJqowfU+fYWEScDxgiU= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183922 Archived-At: On Mon 16 Mar 2015, Daiki Ueno wrote: > Daiki Ueno writes: > >>> BTW, what happened with your earlier `make-process' suggestion? >> >> I'm still willing to work on that, but just wanted to be sure that my >> desired feature (additional pipes) could be implemented atop of it, > > So here it is. This merely adds a new function `make-process' as an > alternative form of `start-process', and use it in the `start-process' > implementation. No extra feature has been added by now. > > All tests succeeded with this, except file-notify-tests, which is > failing without the patch. Reviews appreciated. As you are extending code in this area, perhaps you could consider a feature request. start-process assumes that the system is capable of handling shebang lines in shell scripts and launching them by executing a shell. This is not supported by Windows, and so does not work in the native Windows builds of emacs. It would be useful to have a way to have start-process have an option to start the new process via a shell, so that existing code that assumes that it can use start-process with an executable shell script can also be made to work on Windows. AndyM