From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Suspicious warning in W64 build
Date: Thu, 14 Sep 2017 22:17:26 +0100 [thread overview]
Message-ID: <86a81xrndl.fsf@gmail.com> (raw)
In-Reply-To: 83r2v9masw.fsf@gnu.org
On Thu 14 Sep 2017, Eli Zaretskii wrote:
>> Date: Tue, 12 Sep 2017 21:38:24 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: rcopley@gmail.com, emacs-devel@gnu.org
>>
>> > From: Fabrice Popineau <fabrice.popineau@centralesupelec.fr>
>> > Date: Tue, 12 Sep 2017 20:01:58 +0200
>> > Cc: Richard Copley <rcopley@gmail.com>, Emacs developers <emacs-devel@gnu.org>
>> >
>> > As an alternative, I can provide them.
>> > I have the same install with the same warnings.
>> >
>> > Should you want them, they are at this address :
>> > https://drive.google.com/file/d/0BzJyP_aI_ouHOWR6YXZ1LTRiam8/view?usp=sharing
>>
>> Thanks. I think I see the problems, or at least some of them, but I
>> need to think how to solve this for all the supported MinGW versions
>> to work correctly.
>
> It was a mess, but I hope I fixed these warnings now. Please try the
> latest master and see if any fallout remains.
There are still some issues with the pI format. This seems to fix them:
diff --git a/src/lisp.h b/src/lisp.h
index c5aea9c34c..f522e5ee1c 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -99,7 +99,7 @@ enum { EMACS_INT_WIDTH = LLONG_WIDTH, EMACS_UINT_WIDTH = ULLONG_WIDTH };
later and the runtime version is 5.0.0 or later. Otherwise,
printf-like functions are declared with __ms_printf__ attribute,
which will cause a warning for %lld etc. */
-# if defined __MINGW32__ \
+# if defined __MINGW32__ && !defined MINGW_W64 \
&& (!defined __USE_MINGW_ANSI_STDIO \
|| !(GNUC_PREREQ (6, 0, 0) && __MINGW32_MAJOR_VERSION >= 5))
# define pI "I64"
There are also several similar warnings in unexw32.c due to signed/unsigned mismatch:
../../src/unexw32.c: In function 'copy_executable_and_dump_data':
../../src/unexw32.c:503:10: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'long long int' [-Wformat=]
printf ("\t0x%"pDWP" Offset in input file.\n", s - p_infile->file_base); \
^ ~~~~~~~~~~~~~~~
../../src/unexw32.c:553:3: note: in expansion of macro 'COPY_CHUNK'
COPY_CHUNK ("Copying DOS header...", dos_header,
^~~~~~~~~~
../../src/unexw32.c:475:21: note: format string is defined here
# define pDWP "16llx"
^
Should these be using the ptrdiff_t formatter pD from lisp.h ?
AndyM
next prev parent reply other threads:[~2017-09-14 21:17 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 13:38 Suspicious warning in W64 build Angelo Graziosi
2017-09-05 14:04 ` Richard Copley
2017-09-07 15:16 ` Eli Zaretskii
2017-09-07 15:42 ` Angelo Graziosi
2017-09-07 17:52 ` Richard Copley
2017-09-07 17:58 ` Richard Copley
2017-09-07 19:00 ` Angelo Graziosi
2017-09-07 19:21 ` Richard Copley
2017-09-09 4:58 ` Herring, Davis
2017-09-09 9:55 ` Richard Copley
2017-09-09 10:20 ` Eli Zaretskii
2017-09-09 11:24 ` Angelo Graziosi
2017-09-09 13:25 ` Eli Zaretskii
2017-09-09 11:16 ` Angelo Graziosi
2017-09-07 18:58 ` Eli Zaretskii
2017-09-07 19:26 ` Paul Eggert
2017-09-07 19:50 ` Richard Copley
2017-09-07 20:02 ` Richard Copley
2017-09-08 6:49 ` Eli Zaretskii
2017-09-08 8:02 ` Eli Zaretskii
2017-09-08 19:31 ` Richard Copley
2017-09-08 20:17 ` Eli Zaretskii
2017-09-08 21:08 ` Richard Copley
2017-09-08 21:37 ` Richard Copley
2017-09-09 7:37 ` Eli Zaretskii
2017-09-08 22:20 ` Richard Copley
2017-09-09 7:33 ` Eli Zaretskii
2017-09-09 9:36 ` Richard Copley
2017-09-09 10:42 ` Eli Zaretskii
2017-09-09 10:52 ` Eli Zaretskii
2017-09-09 11:17 ` Richard Copley
2017-09-09 16:07 ` Eli Zaretskii
2017-09-10 1:01 ` Richard Copley
2017-09-10 14:40 ` Eli Zaretskii
2017-09-10 19:14 ` Richard Copley
2017-09-10 19:38 ` Angelo Graziosi
2017-09-11 16:17 ` Eli Zaretskii
2017-09-11 22:21 ` Angelo Graziosi
2017-09-11 16:39 ` Óscar Fuentes
2017-09-11 17:20 ` Eli Zaretskii
2017-09-12 17:49 ` Eli Zaretskii
2017-09-12 18:01 ` Fabrice Popineau
2017-09-12 18:37 ` Richard Copley
2017-09-12 18:59 ` Eli Zaretskii
2017-09-12 19:14 ` Richard Copley
2017-09-12 18:38 ` Eli Zaretskii
2017-09-14 17:47 ` Eli Zaretskii
2017-09-14 19:34 ` Richard Copley
2017-09-15 8:54 ` Eli Zaretskii
2017-09-15 23:05 ` Richard Copley
2017-09-16 6:40 ` Eli Zaretskii
2017-09-16 8:19 ` Richard Copley
2017-09-16 8:34 ` Richard Copley
2017-09-16 8:54 ` Eli Zaretskii
2017-09-16 9:07 ` Richard Copley
2017-09-16 11:54 ` Fabrice Popineau
2017-09-16 8:52 ` Eli Zaretskii
2017-09-15 8:59 ` Eli Zaretskii
2017-09-15 14:43 ` Eli Zaretskii
2017-09-17 6:42 ` Paul Eggert
2017-09-17 7:14 ` Richard Copley
2017-09-17 14:31 ` Eli Zaretskii
2017-09-17 6:40 ` Paul Eggert
2017-09-17 14:29 ` Eli Zaretskii
2017-09-17 16:39 ` Fabrice Popineau
2017-09-17 16:52 ` Eli Zaretskii
2017-09-18 0:26 ` Paul Eggert
2017-09-18 11:47 ` Fabrice Popineau
2017-09-18 14:46 ` Eli Zaretskii
2017-09-18 0:01 ` Richard Stallman
2017-09-14 19:36 ` Fabrice Popineau
2017-09-14 21:17 ` Andy Moreton [this message]
2017-09-15 6:55 ` Fabrice Popineau
2017-09-15 9:12 ` Eli Zaretskii
2017-09-15 15:33 ` Fabrice Popineau
2017-09-15 15:45 ` Eli Zaretskii
2017-09-15 18:15 ` Fabrice Popineau
2017-09-15 19:00 ` Eli Zaretskii
2017-09-15 21:02 ` Fabrice Popineau
2017-09-16 7:45 ` Eli Zaretskii
2017-09-17 7:01 ` Paul Eggert
2017-09-17 14:31 ` Eli Zaretskii
2017-09-17 14:52 ` Philipp Stephani
2017-09-17 22:34 ` Paul Eggert
2017-09-17 17:07 ` Paul Eggert
2017-09-17 17:14 ` Eli Zaretskii
2017-09-17 18:53 ` Paul Eggert
2017-09-17 19:30 ` Eli Zaretskii
2017-09-17 20:34 ` Paul Eggert
2017-09-18 2:30 ` Eli Zaretskii
2017-09-18 4:52 ` Paul Eggert
2017-09-18 14:41 ` Eli Zaretskii
2017-09-18 17:35 ` Paul Eggert
2017-09-18 17:58 ` Andy Moreton
2017-09-19 9:05 ` Paul Eggert
2017-09-18 18:01 ` Eli Zaretskii
2017-09-17 20:45 ` Paul Eggert
2017-09-16 13:17 ` Andy Moreton
2017-09-16 13:46 ` Eli Zaretskii
2017-09-16 18:57 ` Richard Copley
2017-09-16 19:21 ` Eli Zaretskii
2017-09-15 9:03 ` Eli Zaretskii
2017-09-09 8:49 ` Angelo Graziosi
2017-09-09 10:37 ` Eli Zaretskii
2017-09-09 11:32 ` Angelo Graziosi
2017-09-09 13:28 ` Eli Zaretskii
2017-09-09 13:33 ` Fabrice Popineau
2017-09-09 14:55 ` Angelo Graziosi
2017-09-09 16:37 ` Eli Zaretskii
2017-09-09 18:38 ` Angelo Graziosi
2017-09-09 18:59 ` Eli Zaretskii
2017-09-09 21:29 ` Angelo Graziosi
2017-09-10 14:56 ` Eli Zaretskii
2017-09-10 15:45 ` Angelo Graziosi
2017-09-10 16:02 ` Eli Zaretskii
2017-09-10 18:45 ` Angelo Graziosi
2017-09-10 19:43 ` Eli Zaretskii
2017-09-09 15:40 ` Angelo Graziosi
2017-09-09 16:40 ` Eli Zaretskii
2017-09-09 18:33 ` Fabrice Popineau
2017-09-07 20:20 ` Eli Zaretskii
2017-09-07 21:59 ` Angelo Graziosi
2017-09-08 8:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a81xrndl.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).