From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use get_key_arg to parse keyword arguments in json_parse_object_type Date: Tue, 26 Dec 2017 11:11:12 -0800 Organization: UCLA Computer Science Department Message-ID: <86a708a7-1b70-09e1-8d24-808d23a07e6b@cs.ucla.edu> References: <20171220063930.19227-1-vibhavp@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1514315406 29065 195.159.176.226 (26 Dec 2017 19:10:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 26 Dec 2017 19:10:06 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 To: Vibhav Pant , Philipp Stephani , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 26 20:10:01 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eTubs-0006u1-UZ for ged-emacs-devel@m.gmane.org; Tue, 26 Dec 2017 20:09:57 +0100 Original-Received: from localhost ([::1]:53314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eTudr-0002Dq-Pa for ged-emacs-devel@m.gmane.org; Tue, 26 Dec 2017 14:11:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eTudC-0002Dc-OG for emacs-devel@gnu.org; Tue, 26 Dec 2017 14:11:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eTud9-0002gf-Dr for emacs-devel@gnu.org; Tue, 26 Dec 2017 14:11:18 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43712) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eTud9-0002fh-80 for emacs-devel@gnu.org; Tue, 26 Dec 2017 14:11:15 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6ECA2161548; Tue, 26 Dec 2017 11:11:13 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id n0GTX4vQhfmp; Tue, 26 Dec 2017 11:11:12 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B227E161535; Tue, 26 Dec 2017 11:11:12 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sPOG79BRVLJc; Tue, 26 Dec 2017 11:11:12 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8D67B16141B; Tue, 26 Dec 2017 11:11:12 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221422 Archived-At: John Wiegley wrote: > I approve of the patch, Vibhav. I'm suprised we don't have a SAFE_CALLOC > macro, though, to avoid having to use memset immediately after. I guess Vibhav's future patches will make this issue moot, as the change doesn't make sense by itself; it merely substitutes a less-efficient implementation for a more-efficient one. Perhaps Vibhav's future changes will pass the argument without memsetting it, for example. It would be helpful to know what the future changes are, as it's hard to tell whether the proposed patch is a good idea without seeing it in the context of the future patches.