From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: {PATCH] continuous scroll for doc-view (FOR REVIEW)) Date: Fri, 14 Jan 2022 10:03:20 +0200 Organization: LINKOV.NET Message-ID: <86a6fypz3p.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36954"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Emacs Devel To: dalanicolai Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 14 09:22:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8HrB-0009Td-Ka for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 09:22:45 +0100 Original-Received: from localhost ([::1]:52850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8HrA-0000Rz-Nr for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 03:22:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8HoC-0006UC-5V for emacs-devel@gnu.org; Fri, 14 Jan 2022 03:19:41 -0500 Original-Received: from [2001:4b98:dc4:8::230] (port=51321 helo=relay10.mail.gandi.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8HoA-0002in-7M for emacs-devel@gnu.org; Fri, 14 Jan 2022 03:19:39 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id C6602240014; Fri, 14 Jan 2022 08:19:31 +0000 (UTC) In-Reply-To: (dalanicolai@gmail.com's message of "Thu, 13 Jan 2022 11:53:45 +0100") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4b98:dc4:8::230 (failed) Received-SPF: pass client-ip=2001:4b98:dc4:8::230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284735 Archived-At: > I'd really like to mention that I get no hits when searching for that > thread (actually searching > for 'the original thread') when searching on `multi image PDF` in the Emacs > devel archive. > (This time) it is not due to too many results. Would be great if you could > inform me why that does not work. Trying to search any recent subject shows that indexing on mailing lists was disabled for a few last months. > So I will attach two files here, the first is an 'adapted' bookroll.el > file, and the second is a > a modified doc-view file that implements the first 'rudimentary' continuous > scroll for PDF > documents(despite the subject title of this message, I am simply attaching > the file, > as you can then more simply load and try it, while I guess you must be > capable of diffing it with > the latest doc-view.el file yourself ;). Thanks, if you want you could attach whole files, because program files take almost no space on mailing list archives, so this is not a problem (the problem is when someone posts large screenshots, and even a video). Or you can just make a copy of doc-view.el in your repository, and send a message when you update it. > I am not sure if the bookroll-mode should be a separate package (like image-mode), > or that it could just get merged into doc-view. But it is as it is for the > development process. If it could be used for other images such as for image galleries, then it should be a separate package like image-mode. > To understand the approach of bookmark.el, it is probably most useful to > look at the Proof > of Concept file to which I have linked already above. It simply draws a > triplet of images (pages) > for each page (and a doublet for the first and last pages), and then it > uses a 'currently-displayed-images' list, and refreshes pages when > necessary by comparing with that list. The current page is the page that > takes more than half of the window height. A triplet or a doublet means that the scroll bar can't be used for scrolling all pages? Have you tried to prefill with overlays for all pages?