From: Juri Linkov <juri@linkov.net>
To: Robert Pluim <rpluim@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: emacs-28 a866674b2a: Fix inaccuracies in "lax search" documentation
Date: Wed, 31 Aug 2022 20:13:45 +0300 [thread overview]
Message-ID: <86a67kjpyu.fsf@mail.linkov.net> (raw)
In-Reply-To: <87a67kjqqw.fsf@gmail.com> (Robert Pluim's message of "Wed, 31 Aug 2022 18:56:55 +0200")
> Juri> Wouldn't it be cleaner to use just (read-char-from-minibuffer "Character: ")
> Juri> where you can either type a character directly or use 'C-x 8 RET'
> Juri> to insert a character by its name.
> >>
> >> I guess that works as well, but then youʼre assuming knowledge of 'C-x
> >> 8 RETʼ. I canʼt come up with a strong argument either ways, so Iʼm
> >> going to chicken out here and see what Eli says ☺️
>
> Eli> Eli says that he was mightily surprised to see that just typing a
> Eli> character at the prompt didn't take that character literally, but
> Eli> instead interpreted it as a hex codepoint.
>
> That pleads for `read-char-from-minibuffer', except that
>
> (read-char-from-minibuffer "Character: ") RET
> C-x 8 RET
> LATIN SMALL LETTER A WITH DIAERESIS
> => [Wrong Answer]
>
> which pleads for extending `read-char-by-name' to not do that single
> character hex thing.
I see it the other way around - that pleads for fixing
`read-char-from-minibuffer':
```
diff --git a/lisp/subr.el b/lisp/subr.el
index 2ffc594997..71fb9f3875 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -3327,7 +3327,6 @@ read-char-from-minibuffer-map
(set-keymap-parent map minibuffer-local-map)
(define-key map [remap self-insert-command] #'read-char-from-minibuffer-insert-char)
- (define-key map [remap exit-minibuffer] #'read-char-from-minibuffer-insert-other)
(define-key map [remap recenter-top-bottom] #'minibuffer-recenter-top-bottom)
(define-key map [remap scroll-up-command] #'minibuffer-scroll-up-command)
```
Then
(read-char-from-minibuffer "Character: ") RET
C-x 8 RET LATIN SMALL LETTER A WITH DIAERESIS RET
RET
next prev parent reply other threads:[~2022-08-31 17:13 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165875050243.3275.8867100069985547389@vcs2.savannah.gnu.org>
[not found] ` <20220725120142.D1283C0F203@vcs2.savannah.gnu.org>
2022-07-25 13:01 ` emacs-28 a866674b2a: Fix inaccuracies in "lax search" documentation Robert Pluim
2022-07-25 13:43 ` Eli Zaretskii
2022-07-25 14:48 ` Robert Pluim
2022-07-25 16:02 ` Eli Zaretskii
2022-07-26 12:52 ` Robert Pluim
2022-07-26 13:16 ` Eli Zaretskii
2022-07-26 14:23 ` Robert Pluim
2022-07-26 16:06 ` Eli Zaretskii
2022-07-26 16:54 ` Robert Pluim
2022-07-26 17:15 ` Eli Zaretskii
2022-07-27 7:54 ` Robert Pluim
2022-07-27 11:32 ` Eli Zaretskii
2022-07-25 17:52 ` Juri Linkov
2022-07-25 18:15 ` Eli Zaretskii
2022-07-25 18:42 ` Juri Linkov
2022-07-25 19:49 ` Juri Linkov
2022-07-26 7:59 ` Robert Pluim
2022-07-26 12:16 ` Eli Zaretskii
2022-07-27 7:46 ` Juri Linkov
2022-07-27 8:13 ` Robert Pluim
2022-07-27 11:32 ` Eli Zaretskii
2022-07-27 18:54 ` Juri Linkov
2022-07-27 19:23 ` Eli Zaretskii
2022-07-27 19:55 ` Juri Linkov
2022-07-28 5:40 ` Eli Zaretskii
2022-07-28 6:07 ` Eli Zaretskii
2022-07-28 7:13 ` Juri Linkov
2022-07-28 7:56 ` Eli Zaretskii
2022-07-28 7:10 ` Juri Linkov
2022-07-28 7:55 ` Eli Zaretskii
2022-07-28 19:40 ` Juri Linkov
2022-08-30 7:29 ` Juri Linkov
2022-08-31 8:49 ` Robert Pluim
2022-08-31 16:09 ` Juri Linkov
2022-08-31 16:36 ` Robert Pluim
2022-08-31 16:40 ` Eli Zaretskii
2022-08-31 16:56 ` Robert Pluim
2022-08-31 17:13 ` Juri Linkov [this message]
2022-08-31 17:22 ` Eli Zaretskii
2022-08-31 17:26 ` Robert Pluim
2022-08-31 17:29 ` [External] : " Drew Adams
2022-08-31 18:04 ` Juri Linkov
2022-08-31 20:14 ` Stefan Monnier
2022-09-01 7:22 ` Juri Linkov
2022-09-01 8:14 ` Robert Pluim
2022-09-01 11:34 ` Eli Zaretskii
2022-09-01 12:23 ` Robert Pluim
2022-09-01 13:00 ` Stefan Monnier
2022-09-01 13:07 ` Robert Pluim
2022-09-01 15:28 ` Robert Pluim
2022-09-01 15:30 ` Eli Zaretskii
2022-09-01 15:58 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a67kjpyu.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).