From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.devel Subject: Re: Merging feature/android Date: Fri, 17 Mar 2023 09:42:58 +0100 Message-ID: <86a60bn4z1.fsf@gnu.org> References: <87edq7ztks.fsf.ref@yahoo.com> <86sfe7mqms.fsf@gnu.org> <87r0tr79oe.fsf@yahoo.com> <86jzzjmp9h.fsf@gnu.org> <87mt4f788u.fsf@yahoo.com> <83fsa7s3yz.fsf@gnu.org> <87edpq7tke.fsf@yahoo.com> <875yb27qe8.fsf@yahoo.com> <87ttym5vgj.fsf@yahoo.com> <87sfe540or.fsf@yahoo.com> <86bkkt3wpb.fsf@gnu.org> <837cvhq8m3.fsf@gnu.org> <864jqkzz3p.fsf@gnu.org> <835yb0rjel.fsf@gnu.org> <86zg8cyjvq.fsf@gnu.org> <834jqkrdk6.fsf@gnu.org> <86pm98y66e.fsf@gnu.org> <83zg8cpj6h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37819"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: luangruo@yahoo.com, corwin@bru.st, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 17 09:44:21 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd5hE-0009cc-TB for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Mar 2023 09:44:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pd5gV-0007vo-TX; Fri, 17 Mar 2023 04:43:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd5gR-0007ua-1F for emacs-devel@gnu.org; Fri, 17 Mar 2023 04:43:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd5gQ-0006UU-I8; Fri, 17 Mar 2023 04:43:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=jYq0AynKPBlwxBrIsMTb7y8Wtw9nhiQGUsgrB8rhG5w=; b=qNww79SZbfH+VLp/ner+ OD2nee8hOdsBdP6xXunNh9fZvqVjVPLjthU1i+q9lNe9waCWOKpLvJyjD1UCeueRw9RBWjPPbIgQD pLJbD80R3Ihx0MXfUYP/HRDwDagviaJUVJ6pVQ/+mAf6P4vP8OKEwIAQQSKIk7h3EO449jp+ZdH1A 5Z/5Rjc8STQ7OZE9bRMTBRSxgQtz4QF+oiAZAX7RDeD0A7VLRKEdmje547rMqxFl00Ygydf9X+GvS 1srylDLx26NL3yWAWBdWXsQS0thMnF6hV8ID5uGu8eon7Yw2XU0NIkyt1CVOTPgsEZn/j39WEIP6Q hMHXkzZ2lqZP8A==; Original-Received: from p5b326a86.dip0.t-ipconnect.de ([91.50.106.134] helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd5g9-0000PH-Id; Fri, 17 Mar 2023 04:43:30 -0400 In-Reply-To: <83zg8cpj6h.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Mar 2023 21:53:10 +0200") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304539 Archived-At: Eli Zaretskii writes: > That doesn't necessarily prove they are the same. Please compare the > values of WARN_CFLAGS in src/Makefile between the two branches. Thanks. This is from master (line breaks added manually): WARN_CFLAGS = -fno-common -Wall -Warith-conversion -Wdate-time -Wdisabled-optimization -Wdouble-promotion -Wduplicated-cond -Wextra -Wformat-signedness -Winit-self -Winvalid-pch -Wlogical-op -Wmissing-declarations -Wmissing-include-dirs -Wmissing-prototypes -Wnested-externs -Wnull-dereference -Wold-style-definition -Wopenmp-simd -Wpacked -Wpointer-arith -Wstrict-prototypes -Wsuggest-attribute=noreturn -Wsuggest-final-methods -Wsuggest-final-types -Wtrampolines -Wuninitialized -Wunknown-pragmas -Wunused-macros -Wvariadic-macros -Wvector-operation-performance -Wwrite-strings -Warray-bounds=2 -Wattribute-alias=2 -Wformat=2 -Wformat-truncation=2 -Wimplicit-fallthrough=5 -Wshift-overflow=2 -Wuse-after-free=3 -Wvla-larger-than=4031 -Wno-missing-field-initializers -Wno-override-init -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-format-nonliteral -Wno-bidi-chars -Wno-pointer-sign This is from feature/android: WARN_CFLAGS = And while looking at the diff: master uses the -isystem flag, feature branch uses -I, e.g.: WEBP_CFLAGS= -isystem C:/msys64/mingw64/include/webp (master) WEBP_CFLAGS= -IC:/msys64/mingw64/include/webp (feature/android) Best, Arash