unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: MINI-PATCH: add how to turn auto-completion in test buffers off
Date: Fri, 05 Apr 2024 15:41:59 +0300	[thread overview]
Message-ID: <86a5m856co.fsf@gnu.org> (raw)
In-Reply-To: <CAO48Bk-+NYx+qR2udEqE0Eqy+h85cR9_xfY5WfXS-XoW5OHrZw@mail.gmail.com> (message from Pedro Andres Aranda Gutierrez on Fri, 5 Apr 2024 12:25:18 +0200)

> From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> Date: Fri, 5 Apr 2024 12:25:18 +0200
> Cc: emacs-devel@gnu.org
> 
> so you mean something like the attached patch?

Almost, see below.

> diff --git a/doc/emacs/text.texi b/doc/emacs/text.texi
> index cb347d59948..f039c42d46c 100644
> --- a/doc/emacs/text.texi
> +++ b/doc/emacs/text.texi
> @@ -954,6 +954,11 @@ Text Mode
>    Entering Text mode runs the mode hook @code{text-mode-hook}
>  (@pxref{Major Modes}).
>  
> +@vindex text-mode-ispell-word-completion
> +  Entering Text mode also activates auto-complete hints. If you find
> +that this is disturbing for you, set this variable to @code{nil} in
> +your Emacs initialization code.

This is using the wrong tone for describing the issue: it regards
completion hints in Text Mode as a nuisance in most cases.  If it were
such a nuisance, we ought to make it off by default.

Instead, the text should describe the completion hints feature from
the POV of its being useful, and then say that the variable
text-mode-ispell-word-completion controls it.

Also, @vindex generates no text in the formatted manual, so you need
to mention the variable in the text as well, otherwise "this variable"
will allude to something the text doesn't mention.

Finally, please leave two spaces between sentences, per our
conventions.

> --- a/lisp/textmodes/text-mode.el
> +++ b/lisp/textmodes/text-mode.el
> @@ -145,7 +145,10 @@ text-mode
>  You can thus get the full benefit of adaptive filling
>   (see the variable `adaptive-fill-mode').
>  \\{text-mode-map}
> -Turning on Text mode runs the normal hook `text-mode-hook'."
> +Turning on Text mode runs the normal hook `text-mode-hook'.
> +By default, `text-mode-hook' will enable completion at point with
> +candidates supplied by `ispell'. You can turn this off by
> +setting `text-mode-ispell-word-completion' to `nil'."

This part is okay (modulo the 2 spaces between sentences issue).

Thanks.



  reply	other threads:[~2024-04-05 12:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 17:29 MINI-PATCH: add how to turn auto-completion in test buffers off Pedro Andres Aranda Gutierrez
2024-04-04 18:48 ` Eli Zaretskii
2024-04-05 10:25   ` Pedro Andres Aranda Gutierrez
2024-04-05 12:41     ` Eli Zaretskii [this message]
2024-04-05 15:02       ` Pedro Andres Aranda Gutierrez
2024-04-07  6:32         ` Pedro Andres Aranda Gutierrez
2024-04-07  8:00           ` Eli Zaretskii
2024-04-07 10:57             ` Pedro Andres Aranda Gutierrez
2024-04-07 11:48               ` Eli Zaretskii
2024-04-08  5:30                 ` Pedro Andres Aranda Gutierrez
2024-04-08 11:27                   ` Eli Zaretskii
2024-04-08 16:56                     ` Pedro Andres Aranda Gutierrez
2024-04-08 17:37                       ` tomas
2024-04-08 18:38                         ` Eli Zaretskii
2024-04-08 18:43                           ` Emanuel Berg
2024-04-09  4:31                             ` tomas
2024-04-09  5:06                               ` Emanuel Berg
2024-04-09  9:26                                 ` Eli Zaretskii
2024-04-09  9:32                                   ` tomas
2024-04-08 17:57                       ` Eli Zaretskii
2024-04-09  5:22                         ` Pedro Andres Aranda Gutierrez
2024-04-10  8:45                           ` Pedro Andres Aranda Gutierrez
2024-04-10 13:07                             ` Eli Zaretskii
2024-04-10 13:35                               ` tomas
2024-04-10 13:58                                 ` Eli Zaretskii
2024-04-10 14:10                                   ` tomas
2024-04-10 14:45                                     ` Pedro Andres Aranda Gutierrez
2024-04-10 15:26                                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86a5m856co.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=paaguti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).