From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: URGENT - which-key FSF contributor status Date: Sat, 15 Jun 2024 18:19:28 +0300 Message-ID: <86a5jmterj.fsf@gnu.org> References: <87le4r98m9.fsf@jeremybryant.net> <86le4rjv9p.fsf@gnu.org> <87a5l78kc0.fsf@posteo.net> <87msp6o9o4.fsf@jeremybryant.net> <87sexelgnj.fsf@posteo.net> <86wmmqtmkl.fsf@gnu.org> <87wmmqmkh3.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27441"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jb@jeremybryant.net, justin@burkett.cc, emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 15 17:19:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIVBw-0006xm-29 for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jun 2024 17:19:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIVBl-0000Gx-OJ; Sat, 15 Jun 2024 11:19:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIVBk-0000GY-IX for emacs-devel@gnu.org; Sat, 15 Jun 2024 11:19:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIVBj-0001iQ-Hx; Sat, 15 Jun 2024 11:19:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tNoHX9T/Ivz6qwMxu/512AXLqBNxd7zx0cXtX8rTIxI=; b=o19QTNPQkzrA OiD3m856bn9Ez09P2M+tCawgMqWALvJRpJbd+npiexROtjtGaDMDdD4jDYYdNVgj/AUyZVQxjtJSW VJSlPGQMfMD0SdMTc51WHpIg05B6D0d9FcAjVYqy6nfJskQpAF0tBUgVNCUQ1FbrQXeBZcJSZIj0J LqQAVVirmHqtN5OpXo6mMVOZuxueKR87Si3etU2tG4px+QFOEoTk7dA+ciVYZY6TLnzQkNLg9XlkZ 6xBAjj2iJdQ2SuypbqhF6bwNiLOdY4lFwaqR0bcnmzf9sH6PlV2JERpoeTGU4wAMqor8K+wsLNNyW yLt8kVclnWx/keeSVg2aHA==; In-Reply-To: <87wmmqmkh3.fsf@posteo.net> (message from Philip Kaludercic on Sat, 15 Jun 2024 12:58:00 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320153 Archived-At: > From: Philip Kaludercic > Cc: jb@jeremybryant.net, justin@burkett.cc, emacs-devel@gnu.org > Date: Sat, 15 Jun 2024 12:58:00 +0000 > > Eli Zaretskii writes: > > >> From: Philip Kaludercic > >> Cc: Eli Zaretskii , Justin Burkett , > >> emacs-devel@gnu.org > >> Date: Sat, 15 Jun 2024 09:05:52 +0000 > >> > >> We have found out that Bar has completed the CA. That means we can > >> proceed with adding which-key, perhaps even by Emacs 30 (Eli?)? > > > > Yes. If you do this _very_ quickly. > > I have pushed a working branch under "feature/which-key-in-core". > Please take a look to see if I missed something obvious, and if it seems > fine I can merge it into master right away. Thanks. A couple of comments: The :version tags of the defcustoms and deffaces will need to change. Some faces use attributes such as underline or bold without testing for their availability first and without offering any fallbacks if they aren't. Is it okay to have those displayed using the default face?