From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: jb@jeremybryant.net, justin@burkett.cc, emacs-devel@gnu.org
Subject: Re: URGENT - which-key FSF contributor status
Date: Sat, 15 Jun 2024 18:19:28 +0300 [thread overview]
Message-ID: <86a5jmterj.fsf@gnu.org> (raw)
In-Reply-To: <87wmmqmkh3.fsf@posteo.net> (message from Philip Kaludercic on Sat, 15 Jun 2024 12:58:00 +0000)
> From: Philip Kaludercic <philipk@posteo.net>
> Cc: jb@jeremybryant.net, justin@burkett.cc, emacs-devel@gnu.org
> Date: Sat, 15 Jun 2024 12:58:00 +0000
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Philip Kaludercic <philipk@posteo.net>
> >> Cc: Eli Zaretskii <eliz@gnu.org>, Justin Burkett <justin@burkett.cc>,
> >> emacs-devel@gnu.org
> >> Date: Sat, 15 Jun 2024 09:05:52 +0000
> >>
> >> We have found out that Bar has completed the CA. That means we can
> >> proceed with adding which-key, perhaps even by Emacs 30 (Eli?)?
> >
> > Yes. If you do this _very_ quickly.
>
> I have pushed a working branch under "feature/which-key-in-core".
> Please take a look to see if I missed something obvious, and if it seems
> fine I can merge it into master right away.
Thanks. A couple of comments:
The :version tags of the defcustoms and deffaces will need to change.
Some faces use attributes such as underline or bold without testing
for their availability first and without offering any fallbacks if
they aren't. Is it okay to have those displayed using the default
face?
next prev parent reply other threads:[~2024-06-15 15:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87le4r98m9.fsf@jeremybryant.net>
[not found] ` <86le4rjv9p.fsf@gnu.org>
[not found] ` <87a5l78kc0.fsf@posteo.net>
[not found] ` <87msp6o9o4.fsf@jeremybryant.net>
2024-06-15 9:05 ` URGENT - which-key FSF contributor status Philip Kaludercic
2024-06-15 12:30 ` Eli Zaretskii
2024-06-15 12:58 ` Philip Kaludercic
2024-06-15 14:36 ` Stefan Kangas
2024-06-18 19:06 ` Stefan Kangas
2024-06-18 19:23 ` Philip Kaludercic
2024-06-18 19:30 ` Stefan Kangas
2024-06-18 19:41 ` Philip Kaludercic
2024-06-18 19:42 ` Stefan Kangas
2024-06-18 21:41 ` Philip Kaludercic
2024-06-20 14:26 ` Justin Burkett
2024-06-20 18:25 ` Stefan Kangas
2024-06-20 19:22 ` Philip Kaludercic
2024-06-20 21:16 ` Justin Burkett
2024-06-20 21:45 ` Stefan Kangas
2024-06-15 15:19 ` Eli Zaretskii [this message]
2024-06-15 17:09 ` Philip Kaludercic
2024-06-15 17:42 ` Justin Burkett
2024-06-15 17:50 ` Eli Zaretskii
2024-06-18 8:49 ` Philip Kaludercic
2024-06-18 17:37 ` Eli Zaretskii
2024-06-16 19:07 ` Jeremy Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a5jmterj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jb@jeremybryant.net \
--cc=justin@burkett.cc \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).