* Re: master fcb4d89aaa7 2/3: Prefer `memcpy` to `strcpy` in image.c [not found] ` <20240716021300.67222C3534C@vcs2.savannah.gnu.org> @ 2024-07-16 2:54 ` Po Lu 2024-07-16 10:13 ` Eli Zaretskii 0 siblings, 1 reply; 5+ messages in thread From: Po Lu @ 2024-07-16 2:54 UTC (permalink / raw) To: emacs-devel; +Cc: Stefan Kangas Stefan Kangas <stefankangas@gmail.com> writes: > branch: master > commit fcb4d89aaa7bf3ed77aaa4d6d5047a0ec2ed9225 > Author: Stefan Kangas <stefankangas@gmail.com> > Commit: Stefan Kangas <stefankangas@gmail.com> > > Prefer `memcpy` to `strcpy` in image.c Could we agree not to insert pairs of "``" as quotation marks in commit messages, source code comments, and the like? It gives me the impression of reading a poorly typeset document whose authors were either ignorant of or unwilling to correct directional quotation marks inserted by their input methods. Thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master fcb4d89aaa7 2/3: Prefer `memcpy` to `strcpy` in image.c 2024-07-16 2:54 ` master fcb4d89aaa7 2/3: Prefer `memcpy` to `strcpy` in image.c Po Lu @ 2024-07-16 10:13 ` Eli Zaretskii 2024-07-16 12:15 ` Philip Kaludercic 0 siblings, 1 reply; 5+ messages in thread From: Eli Zaretskii @ 2024-07-16 10:13 UTC (permalink / raw) To: Po Lu; +Cc: emacs-devel, stefankangas > From: Po Lu <luangruo@yahoo.com> > Cc: Stefan Kangas <stefankangas@gmail.com> > Date: Tue, 16 Jul 2024 10:54:03 +0800 > > Stefan Kangas <stefankangas@gmail.com> writes: > > > branch: master > > commit fcb4d89aaa7bf3ed77aaa4d6d5047a0ec2ed9225 > > Author: Stefan Kangas <stefankangas@gmail.com> > > Commit: Stefan Kangas <stefankangas@gmail.com> > > > > Prefer `memcpy` to `strcpy` in image.c > > Could we agree not to insert pairs of "``" as quotation marks in commit > messages, source code comments, and the like? It gives me the > impression of reading a poorly typeset document whose authors were > either ignorant of or unwilling to correct directional quotation marks > inserted by their input methods. Our conventions are to quote 'like this' or `like this' in commit log messages. Please, everybody, don't use the Markdown-style `like this` quoting. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master fcb4d89aaa7 2/3: Prefer `memcpy` to `strcpy` in image.c 2024-07-16 10:13 ` Eli Zaretskii @ 2024-07-16 12:15 ` Philip Kaludercic 2024-07-16 12:21 ` Robert Pluim 2024-07-16 13:34 ` Eli Zaretskii 0 siblings, 2 replies; 5+ messages in thread From: Philip Kaludercic @ 2024-07-16 12:15 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Po Lu, emacs-devel, stefankangas Eli Zaretskii <eliz@gnu.org> writes: >> From: Po Lu <luangruo@yahoo.com> >> Cc: Stefan Kangas <stefankangas@gmail.com> >> Date: Tue, 16 Jul 2024 10:54:03 +0800 >> >> Stefan Kangas <stefankangas@gmail.com> writes: >> >> > branch: master >> > commit fcb4d89aaa7bf3ed77aaa4d6d5047a0ec2ed9225 >> > Author: Stefan Kangas <stefankangas@gmail.com> >> > Commit: Stefan Kangas <stefankangas@gmail.com> >> > >> > Prefer `memcpy` to `strcpy` in image.c >> >> Could we agree not to insert pairs of "``" as quotation marks in commit >> messages, source code comments, and the like? It gives me the >> impression of reading a poorly typeset document whose authors were >> either ignorant of or unwilling to correct directional quotation marks >> inserted by their input methods. > > Our conventions are to quote 'like this' or `like this' in commit log > messages. Please, everybody, don't use the Markdown-style `like this` > quoting. My understanding was that commit logs were to only include 'this this', while `like this' was only to be used in Elisp docstring and comments? -- Philip Kaludercic on peregrine ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master fcb4d89aaa7 2/3: Prefer `memcpy` to `strcpy` in image.c 2024-07-16 12:15 ` Philip Kaludercic @ 2024-07-16 12:21 ` Robert Pluim 2024-07-16 13:34 ` Eli Zaretskii 1 sibling, 0 replies; 5+ messages in thread From: Robert Pluim @ 2024-07-16 12:21 UTC (permalink / raw) To: Philip Kaludercic; +Cc: Eli Zaretskii, Po Lu, emacs-devel, stefankangas >>>>> On Tue, 16 Jul 2024 12:15:02 +0000, Philip Kaludercic <philipk@posteo.net> said: Philip> Eli Zaretskii <eliz@gnu.org> writes: >>> From: Po Lu <luangruo@yahoo.com> >>> Cc: Stefan Kangas <stefankangas@gmail.com> >>> Date: Tue, 16 Jul 2024 10:54:03 +0800 >>> >>> Stefan Kangas <stefankangas@gmail.com> writes: >>> >>> > branch: master >>> > commit fcb4d89aaa7bf3ed77aaa4d6d5047a0ec2ed9225 >>> > Author: Stefan Kangas <stefankangas@gmail.com> >>> > Commit: Stefan Kangas <stefankangas@gmail.com> >>> > >>> > Prefer `memcpy` to `strcpy` in image.c >>> >>> Could we agree not to insert pairs of "``" as quotation marks in commit >>> messages, source code comments, and the like? It gives me the >>> impression of reading a poorly typeset document whose authors were >>> either ignorant of or unwilling to correct directional quotation marks >>> inserted by their input methods. >> >> Our conventions are to quote 'like this' or `like this' in commit log >> messages. Please, everybody, don't use the Markdown-style `like this` >> quoting. Philip> My understanding was that commit logs were to only include 'this this', Philip> while `like this' was only to be used in Elisp docstring and comments? I think that falls in the "strongly recommended but not mandatory" category. From CONTRIBUTE: - Emacs follows the GNU coding standards for ChangeLog entries: see https://www.gnu.org/prep/standards/html_node/Change-Logs.html or run 'info "(standards)Change Logs"'. One exception is that commits still sometimes quote `like-this' (as the standards used to recommend) rather than 'like-this' or ‘like this’ (as they do now), as `...' is so widely used elsewhere in Emacs. (although I notice that the text allows U+2018 and U+2019 as well) Robert -- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master fcb4d89aaa7 2/3: Prefer `memcpy` to `strcpy` in image.c 2024-07-16 12:15 ` Philip Kaludercic 2024-07-16 12:21 ` Robert Pluim @ 2024-07-16 13:34 ` Eli Zaretskii 1 sibling, 0 replies; 5+ messages in thread From: Eli Zaretskii @ 2024-07-16 13:34 UTC (permalink / raw) To: Philip Kaludercic; +Cc: luangruo, emacs-devel, stefankangas > From: Philip Kaludercic <philipk@posteo.net> > Cc: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org, stefankangas@gmail.com > Date: Tue, 16 Jul 2024 12:15:02 +0000 > > Eli Zaretskii <eliz@gnu.org> writes: > > >> From: Po Lu <luangruo@yahoo.com> > >> Cc: Stefan Kangas <stefankangas@gmail.com> > >> Date: Tue, 16 Jul 2024 10:54:03 +0800 > >> > >> Stefan Kangas <stefankangas@gmail.com> writes: > >> > >> > branch: master > >> > commit fcb4d89aaa7bf3ed77aaa4d6d5047a0ec2ed9225 > >> > Author: Stefan Kangas <stefankangas@gmail.com> > >> > Commit: Stefan Kangas <stefankangas@gmail.com> > >> > > >> > Prefer `memcpy` to `strcpy` in image.c > >> > >> Could we agree not to insert pairs of "``" as quotation marks in commit > >> messages, source code comments, and the like? It gives me the > >> impression of reading a poorly typeset document whose authors were > >> either ignorant of or unwilling to correct directional quotation marks > >> inserted by their input methods. > > > > Our conventions are to quote 'like this' or `like this' in commit log > > messages. Please, everybody, don't use the Markdown-style `like this` > > quoting. > > My understanding was that commit logs were to only include 'this this', > while `like this' was only to be used in Elisp docstring and comments? That's my personal preference, but some people still use the other method (and feel strong about it), so I'm willing to accept that. But `like this` is not to be used, neither in log messages nor in comments. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-16 13:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <172109597956.10135.3773889760488581016@vcs2.savannah.gnu.org>
[not found] ` <20240716021300.67222C3534C@vcs2.savannah.gnu.org>
2024-07-16 2:54 ` master fcb4d89aaa7 2/3: Prefer `memcpy` to `strcpy` in image.c Po Lu
2024-07-16 10:13 ` Eli Zaretskii
2024-07-16 12:15 ` Philip Kaludercic
2024-07-16 12:21 ` Robert Pluim
2024-07-16 13:34 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).