From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: gerd.moellmann@t-online.de (Gerd Moellmann) Newsgroups: gmane.emacs.devel Subject: Re: problem of display property [Re: list-charset-chars and unicode-bmp] Date: 28 Jan 2003 13:35:20 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <868yx5jvuf.fsf@gerd.free-bsd.org> References: <87u1g3atvf.fsf@mimuw.edu.pl> <200301210831.RAA03126@etlken.m17n.org> <871y35kej4.fsf@mimuw.edu.pl> <200301281129.UAA16158@etlken.m17n.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1043781087 324 80.91.224.249 (28 Jan 2003 19:11:27 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 28 Jan 2003 19:11:27 +0000 (UTC) Cc: jsbien@mimuw.edu.pl Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18db8j-0008WC-00 for ; Tue, 28 Jan 2003 20:11:21 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18dbDX-0004Yi-00 for ; Tue, 28 Jan 2003 20:16:20 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18dbA9-000484-01 for emacs-devel@quimby.gnus.org; Tue, 28 Jan 2003 14:12:49 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18db8z-0002ns-00 for emacs-devel@gnu.org; Tue, 28 Jan 2003 14:11:37 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18db8n-0002Vh-00 for emacs-devel@gnu.org; Tue, 28 Jan 2003 14:11:25 -0500 Original-Received: from mailout10.sul.t-online.com ([194.25.134.21]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18db7n-0001py-00 for emacs-devel@gnu.org; Tue, 28 Jan 2003 14:10:23 -0500 Original-Received: from fwd07.sul.t-online.de by mailout10.sul.t-online.com with smtp id 18dUxx-0006PS-0F; Tue, 28 Jan 2003 13:35:49 +0100 Original-Received: from gerd.free-bsd.org (520015515780-0001@[80.130.112.99]) by fwd07.sul.t-online.com with esmtp id 18dUxk-0PGIZkC; Tue, 28 Jan 2003 13:35:36 +0100 Original-Received: from gerd.free-bsd.org (localhost [127.0.0.1]) by gerd.free-bsd.org (8.12.6/8.12.6) with ESMTP id h0SCZYwx000468; Tue, 28 Jan 2003 13:35:34 +0100 (CET) (envelope-from gerd.moellmann@t-online.de) Original-Received: (from gerd@localhost) by gerd.free-bsd.org (8.12.6/8.12.6/Submit) id h0SCZKnb000465; Tue, 28 Jan 2003 13:35:20 +0100 (CET) X-Authentication-Warning: gerd.free-bsd.org: gerd set sender to gerd.moellmann@t-online.de using -f Original-To: Kenichi Handa In-Reply-To: <200301281129.UAA16158@etlken.m17n.org> Original-Lines: 25 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-Sender: 520015515780-0001@t-dialin.net Original-cc: d.love@dl.ac.uk Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:11168 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:11168 Kenichi Handa writes: > Gerd, could you help me? What do you think about it? The relevant > codes are not changed from 21.1, so I think any new codes added > later doesn't affect it. It also means that this bug has been there > from 21.1. Hi Kenichi! I admit I haven't checked your patch in depth; please bear with me if I've overlooked something. When current glyphs are reused, their positions are adjusted for the changes in the buffer since the glyphs were made current. The function try_window_id is one such example. I didn't see this being done for the new slot you added to struct glyph. (Insofar, the comment of struct glyph doesn't appear to be that devious :).) Be it as it may, I think I'd rather try to avoid enlarging struct glyph. Instead, I'd try using the function string_buffer_position in the cursor position computation. Strings aren't displayed frequently, so the additional function calls shouldn't matter, and anyway, enlarging glyphs costs performance too, and that in all cases.