From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: project--completing-read-strict breaks ada-mode project completion table Date: Sun, 20 Jan 2019 11:34:40 -0800 Message-ID: <868szfm8bz.fsf@stephe-leake.org> References: <20180922154639.23195.66360@vcs0.savannah.gnu.org> <20180922154640.9D58220310@vcs0.savannah.gnu.org> <54108dbc-9d12-06ff-3f1d-151118e9b234@yandex.ru> <4e729d1e-bb31-455f-fd44-e99ae5a6b9fa@yandex.ru> <86zhs5r9lr.fsf_-_@stephe-leake.org> <08de4d90-d678-0524-9356-f9a3515bf0c4@yandex.ru> <86a7k2rabi.fsf@stephe-leake.org> <86sgxso27d.fsf@stephe-leake.org> <86fttsntw5.fsf@stephe-leake.org> <86zhrynaaz.fsf@stephe-leake.org> NNTP-Posting-Host: ciao.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ciao.gmane.org 1548012944 219118 195.159.176.228 (20 Jan 2019 19:35:44 GMT) X-Complaints-To: usenet@ciao.gmane.org NNTP-Posting-Date: Sun, 20 Jan 2019 19:35:44 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 20 20:35:42 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1glIsf-000uws-Bv for ged-emacs-devel@m.gmane.org; Sun, 20 Jan 2019 20:35:41 +0100 Original-Received: from localhost ([127.0.0.1]:43553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glIso-000430-HM for ged-emacs-devel@m.gmane.org; Sun, 20 Jan 2019 14:35:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glIs0-000429-Cz for emacs-devel@gnu.org; Sun, 20 Jan 2019 14:35:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glIrw-0006Hp-8L for emacs-devel@gnu.org; Sun, 20 Jan 2019 14:35:00 -0500 Original-Received: from smtp89.ord1d.emailsrvr.com ([184.106.54.89]:47712) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1glIrw-0006An-3M for emacs-devel@gnu.org; Sun, 20 Jan 2019 14:34:56 -0500 Original-Received: from smtp20.relay.ord1d.emailsrvr.com (localhost [127.0.0.1]) by smtp20.relay.ord1d.emailsrvr.com (SMTP Server) with ESMTP id 550C5C0147 for ; Sun, 20 Jan 2019 14:34:42 -0500 (EST) X-Auth-ID: board-president@tomahawk-creek-hoa.com Original-Received: by smtp20.relay.ord1d.emailsrvr.com (Authenticated sender: board-president-AT-tomahawk-creek-hoa.com) with ESMTPSA id 074C0C0146 for ; Sun, 20 Jan 2019 14:34:41 -0500 (EST) X-Sender-Id: board-president@tomahawk-creek-hoa.com Original-Received: from Takver4 ([UNAVAILABLE]. [76.77.182.20]) (using TLSv1.2 with cipher AES256-GCM-SHA384) by 0.0.0.0:25 (trex/5.7.12); Sun, 20 Jan 2019 14:34:42 -0500 In-Reply-To: <86zhrynaaz.fsf@stephe-leake.org> (Stephen Leake's message of "Thu, 17 Jan 2019 15:17:40 -0800") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 184.106.54.89 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232550 Archived-At: Stephen Leake writes: > There's a bug in path-iterator; I've set :ignore-function to ignore any > dir under ".git", but they are showing up anyway. But that demonstrates > how non-unique file names are handled, so it's good for this demo. The bug was not in path-iterator but in the ignore function; args to string-match are reversed. In addition, the function can be simplified, since if dir is ignored, no children of dir will be passed to the function: (defun emacs-project-ignore-dir (dir) "Return non-nil if 'dir' should be ignored in file-completion-table." ;; If DIR is ignored, no children of DIR will be passed to this function. (string-equal ".git" (file-name-nondirectory dir))) -- -- Stephe