From: Stephen Leake <stephen_leake@stephe-leake.org>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Re: improve "next locus from <buffer>" messages
Date: Thu, 04 Apr 2019 05:55:03 -0800 [thread overview]
Message-ID: <868swpdgeg.fsf@stephe-leake.org> (raw)
In-Reply-To: <83sguyc4mm.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Apr 2019 15:54:41 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Stephen Leake <stephen_leake@stephe-leake.org>
>> Date: Wed, 03 Apr 2019 12:53:41 -0800
>>
>> > Comment: why change long-time default behavior based on personal
>> > preferences?
>>
>> These messages are not in emacs-26, so I don't think they count as
>> "long-time".
>
> You are right, sorry. It's just that the changes which introduced
> them were discussed quite some time ago.
Yes. I've only started using master for development recently, so I only
noticed this now.
> But the main issue still stands: why change something based on
> personal preferences? This function is called from many other places:
> xref, multi-occur, even some Dired commands (AFAIR), and it can be
> called intermittently in different contexts. I think displaying the
> context in these situations is generally a good idea.
I agree, but I don't think it makes sense to print the same message over
and over again, when nothing has changed. Isn't there a general
rule to not fill *Messages* with noise?
xref and compile are the only places that change next-error-last-buffer
directly (in the core emacs sources; EPLA packages may also do this).
All of those other places still print the message when the locus has
changed. However, with this patch they only print "next error locus"; I
guess in come cases the "first/current/previous" messages might make
sense.
I'll put back the "first/current/previous", and add a custom option to
control this.
--
-- Stephe
next prev parent reply other threads:[~2019-04-04 13:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 17:50 improve "next locus from <buffer>" messages Stephen Leake
2019-04-03 18:20 ` Eli Zaretskii
2019-04-03 20:53 ` Stephen Leake
2019-04-03 21:22 ` Stephen Leake
2019-04-04 9:26 ` Felician Nemeth
2019-04-04 13:41 ` Stephen Leake
2019-04-04 14:09 ` Dmitry Gutov
2019-04-04 12:54 ` Eli Zaretskii
2019-04-04 13:55 ` Stephen Leake [this message]
2019-04-07 16:55 ` Stephen Leake
2019-04-08 19:21 ` Juri Linkov
2019-04-08 22:16 ` [SPAM UNSURE] " Stephen Leake
2019-04-13 20:56 ` Juri Linkov
2019-04-14 16:25 ` [SPAM UNSURE] " Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868swpdgeg.fsf@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).