From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: Renaming eglot -- or at least add an alias? Date: Wed, 12 Oct 2022 23:03:23 -0700 Message-ID: <868rlkfefo.fsf@stephe-leake.org> References: <86wn9ji3ma.fsf@gmail.com> <86tu4lsnqk.fsf@gmail.com> <8335c0p2fn.fsf@gnu.org> <83leproov6.fsf@gnu.org> <83fsfzonwn.fsf@gnu.org> <5a1e604c-4500-a476-da3d-259d9057a7f0@yandex.ru> <838rlromxu.fsf@gnu.org> <83h70dk3wf.fsf@gnu.org> <83fsfxk30x.fsf@gnu.org> <83r0zdd1cy.fsf@gnu.org> <86lepkftcw.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31184"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (windows-nt) Cc: Eli Zaretskii , Richard Stallman , emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 13 08:07:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oirNd-0007wr-Gz for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Oct 2022 08:07:42 +0200 Original-Received: from localhost ([::1]:56574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oirNb-00067L-2J for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Oct 2022 02:07:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oirJr-00055r-KB for emacs-devel@gnu.org; Thu, 13 Oct 2022 02:03:47 -0400 Original-Received: from gproxy2-pub.mail.unifiedlayer.com ([69.89.18.3]:44892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oirJo-00087t-5G for emacs-devel@gnu.org; Thu, 13 Oct 2022 02:03:45 -0400 Original-Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 3339710045BDE for ; Thu, 13 Oct 2022 06:03:30 +0000 (UTC) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with ESMTP id irJXo5SLfby5yirJXoUUQG; Thu, 13 Oct 2022 06:03:30 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=ErwXEQQA c=1 sm=1 tr=0 ts=6347aa32 a=dWLzHQi6WpdymmZIwiVdBw==:117 a=Fln8i1WyhtedwaIJAdHvmw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=vvvmwbhNdt4A:10:endurance_base64_authed_username_1 a=9i_RQKNPAAAA:8 a=pGLkceISAAAA:8 a=mDV3o1hIAAAA:8 a=d0IBTAVYn1XtgbnwKQ0A:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=YmVLrQmyUoEA:10:uccc_2email_address a=xIHpHBSqFYYjWdlKNEB-:22 a=Ev4oQ7kfJBNsvnoXShoW:22 a=_FVE-zBwftR9WsbkzFJk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1gfd0eZ/579L0iv+T7iJ7RHKugXCSxqRJChEaBX5QW4=; b=Zke40D/u4uQ+IzOn0qHdSCgU// PkYY7wQHLtCBU7BKsOqKIxaWWpX9Eee0lhxLqfPtyJ+OpSrPZQLpcCErTZFvZsrM9bs3R/Sk19Up+ eZ7yv+y5/s31dPyjgKEJg0LpsoR1phrRjMZ/TNB9BsCmywKguDuX9iaAZ+gQP+Pqi8c+vo7cFvG8A yQTYre+2ldKXa3vaDFQIsnQvvGy2nn/Lpaj5KxrwoIy/UQhUICm6H2umeY3qbw0GPQtzlailw1L+t k+YDQNUlZnbr+hURnCn6EY0g4nfpKxjakFcUaytqWdMPB5dkAmHH/iAOCC785c4oFfraiILU6LZUe JlxWeFKg==; Original-Received: from 135-180-197-170.fiber.dynamic.sonic.net ([135.180.197.170]:59573 helo=DESKTOP-G20DCG1) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oirJX-001ew8-F2; Thu, 13 Oct 2022 00:03:27 -0600 In-Reply-To: <86lepkftcw.fsf@stephe-leake.org> (Stephen Leake's message of "Wed, 12 Oct 2022 17:41:03 -0700") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 135.180.197.170 X-Source-L: No X-Exim-ID: 1oirJX-001ew8-F2 X-Source-Sender: 135-180-197-170.fiber.dynamic.sonic.net (DESKTOP-G20DCG1) [135.180.197.170]:59573 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 4 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: pass client-ip=69.89.18.3; envelope-from=stephen_leake@stephe-leake.org; helo=gproxy2-pub.mail.unifiedlayer.com X-Spam_score_int: 16 X-Spam_score: 1.6 X-Spam_bar: + X-Spam_report: (1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297655 Archived-At: Stephen Leake writes: > Yuan Fu writes: > >>> On Oct 11, 2022, at 11:04 PM, Eli Zaretskii wrote: >>>=20 >> IMO in some sense, eglot and major mode sits at the same level, and >> tree-sitter a level lower. Consider this: take imenu as an example. >> Major mode sets imenu-create-index-function for imenu to function. A >> major mode now has two options available, one function uses >> tree-sitter and one don=E2=80=99t. If the user enables eglot, eglot sets >> menu-create-index-function to eglot-imenu, overriding major mode=E2=80= =99s >> function. From this perspective, tree-sitter is just a mechanism a >> major mode could use, not unlike syntax-ppss, while eglot do things >> its own way, replacing parts of the major mode=E2=80=99s functionality w= ith >> its own. >> >> So it=E2=80=99s not really =E2=80=9Ctwo back-ends=E2=80=9D, tree-sitter = and eglot are >> different in fundamental ways. > > I've just finished changing ada-mode 8.0 to be compatible with eglot (not > released yet, but soon), and it now very much treats eglot as one of two > possible backends (with the existing wisi parser and gpr_query the > other, and tree-sitter being a possible third in the future). > > Almost every place where eglot does something by default can be > disabled, by setting eglot-stay-out-of appropriately. > > So major-modes can treat eglot as just an interface to a language > server. > > ada-mode 8.0 provides three variables to control this: > > (defcustom ada-face-backend :options '(none eglot wisi) > > (defcustom ada-indent-backend :options '(none eglot wisi) > > (defcustom ada-xref-backend :options '(gpr_query gnat eglot) > > If you have the current ada_language_server installed, but not the Ada > wisi parser, then ada-face-backend defaults to none, since that server > doesn't support it. Similarly for the other backends. > > I should have initial feedback from beta testers in a month or so. Thinking about this some more, I realized there are other features that the user might want to control: signature help - show the function signature when point is in a function name. ada-mode does not currently do this, and users might want to turn it off. completion - gpr_query does this for ada-mode, but eglot is always better, so it is used if available.=20 diagnostics - error messages from the parser for syntax errors in the file; eglot displays them via flymake. ada-mode also does this (not using flymake) - I have not considered how to handle them fighting each other, but I will probably have to disable one or the other. --=20 -- Stephe