From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Navigating completions from minibuffer Date: Tue, 07 Nov 2023 09:20:45 +0200 Organization: LINKOV.NET Message-ID: <868r7af3v6.fsf@mail.linkov.net> References: <25929.50004.710119.599023@google.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30456"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: "T.V Raman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 07 08:23:32 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0GQu-0007mA-I0 for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Nov 2023 08:23:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0GP3-0003RQ-Du; Tue, 07 Nov 2023 02:21:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0GOo-0002yf-5b for emacs-devel@gnu.org; Tue, 07 Nov 2023 02:21:25 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0GOj-0003C8-RS for emacs-devel@gnu.org; Tue, 07 Nov 2023 02:21:20 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 5E82960004; Tue, 7 Nov 2023 07:21:13 +0000 (UTC) In-Reply-To: <25929.50004.710119.599023@google.com> (T. V. Raman's message of "Mon, 6 Nov 2023 20:55:48 -0800") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312286 Archived-At: --=-=-= Content-Type: text/plain >> This change: >> f0c0ff6bf23 * New option to use arrows in the minibuffer to select completions (bug#59486) >> works really well but appears to introduce a separate problem: >> >> Assume you have a command e.g. foo but also foo-bar and foo-bas. >> >> Earlier you could type M-x foo and press enter to invoke foo. >> >> Now, with the new option enabled, typing >> M-x foo >> appears to require that you first press TAB before pressing RET. > > The problem is that now RET calls minibuffer-choose-completion, > whereas exit-minibuffer is what you want if what you have typed is a > valid completion already; Perhaps we need > minibuffer-choose-completion-or-exit-minibuffer ... Agreed. When a completion candidate is not selected let's use the contents of the minibuffer. Please try this patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=minibuffer-choose-completion-or-exit.patch diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 4e8590989b3..0410e3a0b8d 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -3005,7 +3005,7 @@ minibuffer-visible-completions-map "" (minibuffer-visible-completions-bind #'minibuffer-next-completion) "" (minibuffer-visible-completions-bind #'minibuffer-previous-line-completion) "" (minibuffer-visible-completions-bind #'minibuffer-next-line-completion) - "RET" (minibuffer-visible-completions-bind #'minibuffer-choose-completion) + "RET" (minibuffer-visible-completions-bind #'minibuffer-choose-completion-or-exit) "C-g" (minibuffer-visible-completions-bind #'minibuffer-hide-completions)) @@ -4693,6 +4693,12 @@ minibuffer-choose-completion (let ((completion-use-base-affixes t)) (choose-completion nil no-exit no-quit)))) +(defun minibuffer-choose-completion-or-exit (&optional no-exit no-quit) + (interactive "P") + (condition-case nil + (minibuffer-choose-completion no-exit no-quit) + (error (exit-minibuffer)))) + (defun minibuffer-complete-history () "Complete the minibuffer history as far as possible. Like `minibuffer-complete' but completes on the history items --=-=-=--