From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Flymake Support Indicator Errors in Margin Date: Wed, 13 Mar 2024 14:18:47 +0200 Message-ID: <868r2mtjdk.fsf@gnu.org> References: <87r0gfajlh.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21073"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, emacs-devel@gnu.org To: Elijah G Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 13 13:20:24 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rkNaq-0005HQ-EC for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Mar 2024 13:20:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkNZO-0004XK-JI; Wed, 13 Mar 2024 08:18:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkNZM-0004X2-2r for emacs-devel@gnu.org; Wed, 13 Mar 2024 08:18:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkNZK-0002KU-CU; Wed, 13 Mar 2024 08:18:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=cpnWlbA8ZH3yg63vJuJhYNtqh3RNjfdWLuG0ffZ0E1Y=; b=F7tRNTQK0JfKtTrskSeA LsqiYguXfKgb+q71rfylj1S4HY4lNWyq6O+cBXPAuueklXv3/DOkyRM50av3PF8x2DE/IW/l6ZBTl rwXkdMEq0PJv73IBiKxGWyyR44UgHrfb1kCQhnKUjMMCKKpLHDgby/Nxnjc3GCz0wE2XnVh/DjkS7 yIf2dyiXWe3Wb3lqPIQgMgtrQr4x9y7m5PJCIG5mBuUgWsZx2dFrBkDqbfRjfHqdtZLAiaLYp+Hih WMFM/3VAWsBm/8thHKdcXcvvdMQCmf+28CJNf74e7Izc7nATs3nx8naC0KILRpQY+5kjQQK/zfj1G bDM3nHf8baL2nA==; In-Reply-To: (message from Elijah G on Tue, 12 Mar 2024 11:22:04 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317031 Archived-At: > From: Elijah G > Date: Tue, 12 Mar 2024 11:22:04 -0600 > Cc: emacs-devel@gnu.org > > Thank you, I've fixed my patch. Thanks, I have a few more comments below. > Also I merged every flymake *-bitmap variable > into a single user option. I think this is a mistake: it makes this change backward-incompatible, in the sense that users who had customizations of the options you are removing will now have to rework their customizations. We try to avoid backward-incompatible changes like this as much as possible. It doesn't sound to me like this part of the patch is strictly needed, is it? > + :type '(choice (const :tag "Use Fringes" fringes) > + (const :tag "Use Margins "margins) ^^ A typo there. > +(defcustom flymake-margin-indicators-string '((error "‼" compilation-error) This is a non-ASCII character, so we should either use its ASCII equivalent "!!" or test the display for being able to show it on the screen (since it is likely the margin indicator will be used on TTY frames). Please also accompany your patch with the ChangeLog-style commit log message (see the file CONTRIBUTE for the details).