From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Incorporate package macrostep into Emacs core Date: Sat, 27 Apr 2024 12:52:29 +0300 Message-ID: <868r0zw2si.fsf@gnu.org> References: <87zfvl8r4e.fsf@jeremybryant.net> <874jdspsqb.fsf@bernoul.li> <877cio8fzf.fsf@jeremybryant.net> <87y1b46vhg.fsf@jeremybryant.net> <878r336lvb.fsf@jeremybryant.net> <86y1b1p1ni.fsf@gnu.org> <87y1b0mi4b.fsf@jeremybryant.net> <8734sobkdj.fsf@jeremybryant.net> <86sf0n4sfq.fsf@gnu.org> <87plume5cn.fsf@jeremybryant.net> <867cgtdfhg.fsf@gnu.org> <87edb1duax.fsf@jeremybryant.net> <86pluka80r.fsf@gnu.org> <875xw7ep5d.fsf@jeremybryant.net> <86bk5x1mvb.fsf@gnu.org> <87ttjpceub.fsf@jeremybryant.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37807"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Jeremy Bryant Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 27 11:53:03 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0ejt-0009YR-T5 for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Apr 2024 11:53:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0ejT-0004Wi-0x; Sat, 27 Apr 2024 05:52:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0ejR-0004Ve-2o for emacs-devel@gnu.org; Sat, 27 Apr 2024 05:52:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0ejQ-0000sn-Oz; Sat, 27 Apr 2024 05:52:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HOfk3YsAakdY6KgOuvpRCu2bcgD9C8nhTTfC+M+Oe1o=; b=l79xebkVc6om 7JhmdrX4AQLGkxhcxqptNsJVOFJLsfiRKdrZ8t+whsKuP5+Hw7rQMmru/mn5jGY8KLZw5VlDArtb5 MC3z2jlNvXUDCbPnqvN2J9whm90oV8y70jUtJracF+wpDTENzzUtMhqr6sp1od3iedumMhRhEIpdN IFinIEP4mEKbIvr/fqMEJICEKrO8h+gwowebLFT3G4h0n3MdNoruUwWcStgSufrx0FXPBqRiYtKls kE8p7HrsdR/+ergszlXdQAE5a9p0vIwp74wjLBWP6mxiEKLHqjx1k9BdVop2k5huLeWi+Q6wmnENU QiVZBWpk5QicXj5TOu1nww==; In-Reply-To: <87ttjpceub.fsf@jeremybryant.net> (message from Jeremy Bryant on Thu, 25 Apr 2024 22:27:56 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318182 Archived-At: > From: Jeremy Bryant > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Thu, 25 Apr 2024 22:27:56 +0100 > > Absolutely, sorry, attached is the revised patch I have worked on. Thanks, a few minor comments below. > Subject: [PATCH] Add Macrostep section in manual > > Macrostep is an Emacs Lisp macro-expander useful for exploring and > writing macros. This is based on Jonathan's Oddie's documentation > in the macrostep package. > > * doc/emacs/programs.texi (Programs): Add Macrostep section. > * doc/emacs/emacs.texi (Top): Add detailed menu reference. ^^^^^^^ ^^^ Those TABs should not be there in the commit log message. > +You can use @code{macrostep-mode} to explore Lisp macro definitions, and > +help write new macros, using @kbd{M-x macrostep-expand} when point is > +over a macro. We say "when point is in a macro". "Over" is reserved for mouse pointer. > +@kbd{macrostep} is a minor mode for interactively stepping through the ^^^^^^^^^ "macrostep-mode", I guess? And why @kbd? is that something the user is supposed to type? > +The standard keybindings in @code{macrostep-mode} are the following: > +@table @kbd > +@item e > +@itemx = > +@itemx RET > +@findex macrostep-expand Please move the index entries to _before_ the corresponding @item's, so that following the index entry lands you on the @item, not after it. Otherwise, this LGTM, thanks.