From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master a86c25c91f3 11/13: Prefer -I to -isystem Date: Wed, 17 Jul 2024 16:44:58 +0300 Message-ID: <868qy0gmjp.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24784"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 17 15:45:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sU4yY-0006BG-Mh for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Jul 2024 15:45:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sU4xw-0006ew-NL; Wed, 17 Jul 2024 09:45:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sU4xr-0006PR-Oq for emacs-devel@gnu.org; Wed, 17 Jul 2024 09:45:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sU4xp-0008HJ-WE; Wed, 17 Jul 2024 09:45:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=wMO4SQiWBwM//FvKDcJw2E3zV+rbMIDSoCLrG6rKSKo=; b=aNilRA/t7MB3la +kQm8msUWaGLTbqx58e8WzQ6jaq2vmxws18/hwmbn+pF0/9GMCyDDNtixtkCC5XmzL/SKEVcFCUMl lz9cA3RSxqi5zIpsHH85bxQQE0jc/LfPicV7LhyjBxKOhaJilsGlbE6IrOPcZPSyZ08iOYr2bPDO2 TUqhL6xLSzwHvd9qJkI0IhwEQOi/WUasSL2zyRiLFvzSJE3x8HQyzYD2pCIb6lffP1W0XW1c49VQe KZiJE+lI0fbVCO9ty18xb1czvBQKcszt5qq0ygI4M4raNCBDO7XdxGJvxx4Wuev48zczvl/cIWal5 aMT3cMj7GLQ88jb8qkHw==; X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321752 Archived-At: > branch: master > commit a86c25c91f39a25a93d18c9267e024822c1bc43e > Author: Paul Eggert > > Prefer -I to -isystem > > * configure.ac: Simplify configuration by using -I instead of > -isystem, as -isystem is no longer helpful for suppressing > diagnostics (and likely has not been helpful for years). > Do not suppress -Wsystem-headers, as Gnulib no longer enables it. Paul, Contrary to your "famous last words" above, this change caused the build issue a useless diagnostic in image.c, in a 32-bit build: d:/usr/include/glib-2.0/gobject/gparam.h:157:35: warning: result of '1 << 31' requires 33 bits to represent, but 'int' only has 32 bits [-Wshift-overflow=] 157 | G_PARAM_DEPRECATED = 1 << 31 | ^~ While arguably a bug in Glib, the diagnostic is an annoyance, so I'd like to avoid it. I've verified that -Wno-system-headers doesn't remove it. -Wno-shift-overflow does, but I don't think suppressing that globally is a good idea.