From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: master a86c25c91f3 11/13: Prefer -I to -isystem
Date: Wed, 17 Jul 2024 16:44:58 +0300 [thread overview]
Message-ID: <868qy0gmjp.fsf@gnu.org> (raw)
> branch: master
> commit a86c25c91f39a25a93d18c9267e024822c1bc43e
> Author: Paul Eggert <eggert@cs.ucla.edu>
>
> Prefer -I to -isystem
>
> * configure.ac: Simplify configuration by using -I instead of
> -isystem, as -isystem is no longer helpful for suppressing
> diagnostics (and likely has not been helpful for years).
> Do not suppress -Wsystem-headers, as Gnulib no longer enables it.
Paul,
Contrary to your "famous last words" above, this change caused the
build issue a useless diagnostic in image.c, in a 32-bit build:
d:/usr/include/glib-2.0/gobject/gparam.h:157:35: warning: result of '1 << 31' requires 33 bits to represent, but 'int' only has 32 bits [-Wshift-overflow=]
157 | G_PARAM_DEPRECATED = 1 << 31
| ^~
While arguably a bug in Glib, the diagnostic is an annoyance, so I'd
like to avoid it. I've verified that -Wno-system-headers doesn't
remove it. -Wno-shift-overflow does, but I don't think suppressing
that globally is a good idea.
next reply other threads:[~2024-07-17 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 13:44 Eli Zaretskii [this message]
2024-07-17 15:31 ` master a86c25c91f3 11/13: Prefer -I to -isystem Paul Eggert
2024-07-17 16:04 ` Eli Zaretskii
2024-07-17 16:20 ` Collin Funk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868qy0gmjp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).