From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: igc, macOS avoiding signals Date: Sat, 04 Jan 2025 16:17:41 +0200 Message-ID: <868qrqd5oa.fsf@gnu.org> References: <799DDBC5-2C14-4476-B1E0-7BA2FE9E7901@toadstyle.org> <87msgdkt29.fsf@gmail.com> <86h66lnjrt.fsf@gnu.org> <868qrxnfrw.fsf@gnu.org> <87a5ccl2zx.fsf@gmail.com> <875xn0p3l1.fsf@protonmail.com> <86ldvwm190.fsf@gnu.org> <87cyh8nczh.fsf@protonmail.com> <867c7fncom.fsf@gnu.org> <87pll3ivzs.fsf@gmail.com> <87wmfaof1l.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23047"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pipcet@protonmail.com, gerd.moellmann@gmail.com, spd@toadstyle.org, emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 04 15:18:05 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU4ya-0005ss-9z for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Jan 2025 15:18:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU4yO-0004qc-Dr; Sat, 04 Jan 2025 09:17:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU4yJ-0004qI-Dl for emacs-devel@gnu.org; Sat, 04 Jan 2025 09:17:49 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU4yI-0004pf-A1; Sat, 04 Jan 2025 09:17:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZNKA5i2goSERvcB5bF+3dH7hbFZS41R2bM53AqrimKQ=; b=dtHvHpbt/enk JZwliTaM2bZt9rUJSxvbEKULqUfcrQbx9Dq6D4A0524llKxWFhBttZgDn55seAx8ZNMWP04ujaNYB KfvjGtQfDi7fL3HB1JfW+RuBTti97DQ6zWuJ2IuIdr6eC+E8TbQvNUFsnEfEPlPuDlDsUXVCv4qTa Fs5FgFDsWFbp21AGqFEsmNAoajjmd3JYhEPqy0xkIBdbnRSJHXyiF5STzJ0hP5lqMOJvCOpRX0SaD PiCoX3nrDTsZfrlHTDKVrNWqyTveedIgJIv7WrYRCg7IQ10SQ496DLQxJxcNrTfwUTBLAoFGWgREw RyW08x0eooe2nKAG5+GjzQ==; In-Reply-To: <87wmfaof1l.fsf@gmail.com> (message from Helmut Eller on Sat, 04 Jan 2025 14:59:50 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327667 Archived-At: > From: Helmut Eller > Cc: Pip Cet , gerd.moellmann@gmail.com, > spd@toadstyle.org, emacs-devel@gnu.org > Date: Sat, 04 Jan 2025 14:59:50 +0100 > > On Fri, Jan 03 2025, Helmut Eller wrote: > [...] > > I'm not sure if those differences are acceptable. I also have no good > > idea how to reduce it, except inserting more calls to maybe_quit. > > It seems that calling maybe_quit before and after calling functions > would cure this problem. With the original maybe_quit restored, as in > the attached patch, the foo example looks so: > > 1986 100% main > 1986 100% record-samples > 1986 100% foo > 1214 61% float-time > > Compared to the original > > 1074 54% float-time > > that seems pretty ok. Also the bar example > > 812 80% animate-place-char > 6 0% window-start > 29 2% beginning-of-line > 29 2% delete-char > 6 0% undo-auto-amalgamate > 36 3% insert-char > 390 38% move-to-column > 11 1% undo-auto--undoable-change > > looks quite good to me. > > WDYT? I'd make these extra calls only call the SIGPROF handler if the counter says some signals were missed. There's no need to affect other handlers without a good reason.