From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Replace XChar2b with unsigned in all font backends Date: Mon, 20 May 2019 23:52:30 +0100 Message-ID: <867eak4u35.fsf@gmail.com> References: <87v9y5uh63.fsf@gmail.com> <9A8FC3EE-ED24-49CC-8B13-294FF7F4D4BD@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="26947"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 21 00:53:25 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSr9n-0006rW-8t for ged-emacs-devel@m.gmane.org; Tue, 21 May 2019 00:53:23 +0200 Original-Received: from localhost ([127.0.0.1]:43126 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSr9m-0000PR-6O for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 18:53:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSr9A-0000Oe-Ue for emacs-devel@gnu.org; Mon, 20 May 2019 18:52:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSr99-000605-Ut for emacs-devel@gnu.org; Mon, 20 May 2019 18:52:44 -0400 Original-Received: from [195.159.176.226] (port=41554 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hSr99-0005y1-1W for emacs-devel@gnu.org; Mon, 20 May 2019 18:52:43 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hSr95-00062c-7t for emacs-devel@gnu.org; Tue, 21 May 2019 00:52:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:mUkU8onRo8SYzrDONqYGUc7MMuk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236825 Archived-At: On Mon 20 May 2019, Eli Zaretskii wrote: > On May 20, 2019 7:29:34 PM GMT+01:00, Andy Moreton wrote: >> Please revert this patch to fix the build on master, and then revisit >> these changes after that. >> > You ask to revert because you don't think there's a way of fixing this without reverting? Or fof some other reason? The first order of business is to restore master to a usable state. After that, any amount of time can be taken to revise the non-working patch into something that does not cause the regression. "Don't break the build" is an important rule. A recent Rx patch was reverted by its author because it broke bootstrapping, and then a revised version added later after the problem with the original patch had been fixed. Why should this patch be any different ? AndyM