From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Mon, 03 Jan 2022 23:07:11 +0200 Organization: LINKOV.NET Message-ID: <867dbgtuls.fsf@mail.linkov.net> References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> <871r1v8nhf.fsf@gnus.org> <83ilv7jqm7.fsf@gnu.org> <6a9cd581-1630-4a95-62c4-419603561072@gmx.at> <3499cedf-b170-3045-873d-d45d2972ae13@gmx.at> <0f492ac4-4167-5448-2c74-a5f67950eae4@yandex.ru> <2de2323b-6d34-9263-776b-dbeff036f8f4@gmx.at> <87zgog68ni.fsf@gnus.org> <8dfc6f22-d331-e7c1-b536-2d374197528f@gmx.at> <86v8z26o15.fsf@mail.linkov.net> <9d5f512f-dd10-fb6b-2fe7-db24ed92f7c8@gmx.at> <86y23xuv8g.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36008"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , sdsg@amazon.com, emacs-devel@gnu.org, Eli Zaretskii , Dmitry Gutov To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 03 22:21:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4Ulg-0009Ck-Rj for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jan 2022 22:21:24 +0100 Original-Received: from localhost ([::1]:36414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4Ule-0007yj-Up for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jan 2022 16:21:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4Ukl-0006mz-N3 for emacs-devel@gnu.org; Mon, 03 Jan 2022 16:20:29 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:56853) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4UkZ-0003H9-0B; Mon, 03 Jan 2022 16:20:22 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id B1463FF808; Mon, 3 Jan 2022 21:20:07 +0000 (UTC) In-Reply-To: (martin rudalics's message of "Mon, 3 Jan 2022 19:21:51 +0100") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284103 Archived-At: > Using the tools we have on board we could do something in the spirit of > > (defun display-buffer-match-comint (_buffer action) > (cadr (assq 'comint (cdr action)))) > > (customize-set-variable > 'display-buffer-alist > '((display-buffer-match-comint > display-buffer-same-window (nil)))) > > (pop-to-buffer "*shell*" '(nil . ((comint t)))) Or to add more semantics: (pop-to-buffer "*shell*" '(nil . ((caller . comint)))) > which means that customizing 'display-buffer-alist' with that value on > Emacs 28 will report a mismatch but that's the only mishap that should > happen. > > We also could have 'display-buffer-assq-regexp' do > > (when (or (and (stringp key) > (string-match-p key buffer-name)) > (and (functionp key) > (funcall key buffer-name action)) > (and (symbolp key) > (cadr (assq key (cdr action))))) That will shorten the above example to (customize-set-variable 'display-buffer-alist '((comint display-buffer-same-window (nil)))) ? > so we could do away with 'display-buffer-match-comint' but then we would > have to change the custom type of 'display-buffer-alist' - no great deal > either. WDYT? The obvious downside is the need to tag hundreds of existing calls of display-buffer, pop-to-buffer, etc.