From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Info-mode patch Date: Tue, 27 Jun 2023 21:11:04 +0300 Organization: LINKOV.NET Message-ID: <867cropyh3.fsf@mail.linkov.net> References: <86fs6ertto.fsf@mail.linkov.net> <86wmzpqva6.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29419"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Arthur Miller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 27 20:15:58 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEDEM-0007Sv-KS for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Jun 2023 20:15:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEDDb-0005cV-Ja; Tue, 27 Jun 2023 14:15:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEDDW-0005cF-Ea for emacs-devel@gnu.org; Tue, 27 Jun 2023 14:15:06 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEDDU-0005Kb-2i for emacs-devel@gnu.org; Tue, 27 Jun 2023 14:15:06 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 7C4BC20002; Tue, 27 Jun 2023 18:14:59 +0000 (UTC) In-Reply-To: (Arthur Miller's message of "Tue, 27 Jun 2023 09:54:27 +0200") Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307264 Archived-At: >> But it seems this is not enough because with-selected-frame >> still fails to switch focus to another frame. You need also >> to use select-frame-set-input-focus. > Where it fails? For me it prompts me on correct frame. I didn't want to switch > focus on the info frame. I am aware of select-frame-set-input-focus, have used > it in some test actually. Probably the behaviour depends on the window manager. With my window manager with-selected-frame displays the prompt in another frame, but input is inserted into the original buffer. Maybe we should have a new option whether to use select-frame-set-input-focus? > Have you tested *everything*? Interactively and from lisp? I see no problems with this both interactively and from lisp: #+begin_src emacs-lisp (defmacro with-selected-window-frame (window &rest body) `(let ((old-frame (selected-frame)) (frame (window-frame ,window))) (unless (eq frame old-frame) (select-frame frame 'norecord) (select-frame-set-input-focus frame 'norecord)) (prog1 (with-selected-window ,window ,@body) (select-frame old-frame 'norecord) (select-frame-set-input-focus old-frame 'norecord)))) (defun Info-index-other-window (topic &optional window) (interactive (with-selected-window-frame (info-window) (append (eval (cadr (interactive-form 'Info-index))) (list (selected-window))))) (with-selected-window (or window (info-window)) (Info-index topic))) #+end_src You can't avoid adding the window argument. Otherwise, you need to invent such hacks as sending the window selected by the user to the command body via a symbol property. But in the wrapper command like above there is no problem of adding the window argument to the new command. Maybe it's possible even to write a macro that will generate such wrapper commands automatically from existing commands. It seems you assume that all commands should take a window. But there are no such assumption for most commands that work only in the selected window. OTOH, only -other-window commands switch the window.