From: Eli Zaretskii <eliz@gnu.org>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: emacs-devel@gnu.org, eller.helmut@gmail.com
Subject: Re: MPS: struct window, prev_buffers + next_buffers
Date: Sat, 22 Jun 2024 12:50:28 +0300 [thread overview]
Message-ID: <867cehi9wb.fsf@gnu.org> (raw)
In-Reply-To: <m2le2x4au2.fsf@pro2.fritz.box> (message from Gerd Möllmann on Sat, 22 Jun 2024 10:53:57 +0200)
> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: emacs-devel@gnu.org, eller.helmut@gmail.com
> Date: Sat, 22 Jun 2024 10:53:57 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> But it won't be GC'd anyway, becuase it's marked. And if the buffer in
> >> the cons is killed, it remains in the list. That makes no sense to me.
> >
> > But the code doesn't GC buffers, it just removes them from the
> > prev_buffers and next_buffers lists. If a cons cell of the list is
> > marked, removing the buffer (which could subsequently lead to GC'ing
> > the buffer) might not be expected by the code which uses data that
> > references that buffer, even though the buffer is killed.
>
> You mean the possible change to the cdr of the cons cell could affect
> the client? Hm, that could be the reason. Thanks.
>
> I think I'll try to let window-{next,prev}-buffers clean the list
> before returning it. It doesn't look like something to me that a weak
> vector or something like that could solve. WDYT?
That would work, but what if these functions are not called for a
while?
Also, it would make these simple accessors more expensive.
next prev parent reply other threads:[~2024-06-22 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 7:24 MPS: struct window, prev_buffers + next_buffers Gerd Möllmann
2024-06-22 7:58 ` Eli Zaretskii
2024-06-22 8:13 ` Gerd Möllmann
2024-06-22 8:24 ` Eli Zaretskii
2024-06-22 8:53 ` Gerd Möllmann
2024-06-22 9:50 ` Eli Zaretskii [this message]
2024-06-22 10:25 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867cehi9wb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eller.helmut@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=gerd.moellmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).