From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too Date: Sun, 30 Jun 2024 19:29:29 +0300 Organization: LINKOV.NET Message-ID: <867ce6pwrq.fsf@mail.linkov.net> References: <171823002031.28307.18221225159709452537@vcs2.savannah.gnu.org> <20240612220700.A0F4DC1FB4C@vcs2.savannah.gnu.org> <86h6dwf40q.fsf@mail.linkov.net> <86frtffpdb.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28710"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org, Dmitry Gutov To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 30 18:39:03 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNxZv-0007LM-IF for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Jun 2024 18:39:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNxZ2-0001YI-HL; Sun, 30 Jun 2024 12:38:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNxZ0-0001Y8-4C for emacs-devel@gnu.org; Sun, 30 Jun 2024 12:38:06 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNxYy-0004el-B9 for emacs-devel@gnu.org; Sun, 30 Jun 2024 12:38:05 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 1DFF1240004; Sun, 30 Jun 2024 16:37:59 +0000 (UTC) In-Reply-To: <86frtffpdb.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 14 Jun 2024 19:41:52 +0300") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.193; envelope-from=juri@linkov.net; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320972 Archived-At: >>> Lisp error: (wrong-type-argument number-or-marker-p nil) >> >> Hmm that's quite curious... I can reproduce it also without my change >> in 56537ab0228, FWIW. AFAICT the issue is that icomplete trims the >> prefix from completion candidates before passing them to >> completion-lazy-hilit, while completion--hilit-from-re expects the full >> candidate (prefix included). I'm not deeply familiar with icomplete, >> but maybe calling completion-lazy-hilit before trimming the candidates >> as in the diff below should do the trick? > > Thanks, I confirm with this change icomplete doesn't fail anymore. I don't know what commits caused this, but there is still a regression in another case: 0. emacs -Q 1. M-x icomplete-mode RET 2. M-x rgrep RET foo RET b Error in post-command-hook (icomplete-post-command-hook): (wrong-type-argument number-or-marker-p nil)