From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: Crash while completing symbol with corfu Date: Wed, 03 Jul 2024 18:32:47 +0300 Message-ID: <867ce2bie8.fsf@gnu.org> References: <87y16lbh10.fsf@localhost> <86v81pduw3.fsf@gnu.org> <87sewt87ni.fsf@localhost> <4aK6qyh6gPCldT2u0rLYOuIk7a5Coo8yNf71tkkBOlUh0yk3nU8yjRAZygm9rIzK3kOcyq_IAatIKS2buH7tgA2PwHIOgLTiqQRSoypoOfY=@protonmail.com> <871q4cja54.fsf@localhost> <871q4b6d2v.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37349"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, gerd.moellmann@gmail.com, emacs-devel@gnu.org, eller.helmut@gmail.com To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 03 17:33:55 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sP1zW-0009SY-Ho for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jul 2024 17:33:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sP1yl-0000TJ-NQ; Wed, 03 Jul 2024 11:33:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sP1yk-0000Sx-7k for emacs-devel@gnu.org; Wed, 03 Jul 2024 11:33:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sP1yi-0007kh-HC; Wed, 03 Jul 2024 11:33:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Cop+PS6PpEgLpMKCrbcppyByl4wlFNJiGmrAFbg1s1w=; b=FEJ/l7J6gNAWkU+7810s L6kv6/6BINNF5YvGO8CP/SEsLpnzk6ZARqhlwraopHlYmWK3K7L6+oQvWeWFv8UG36bHtLdfI9GFM qm5nEMyPqlOo9HqMHFLcuPshe5R0bRRuBKErXqb3FgGPZlRW0woK3F6B93Xv+Or8ph+CH7Gnid6UB CbirERLA8xMoEHEY958+qUTGKLiUkrC+KMjQQiIWmb+dFk/gINlUwMOs8QdiV7e/34orZFa7Neuro reKDPxou3TJJw4iwuIsSUOkZo0jEMQyqSvkMh6y2eJYcflHmfMPcvSTUbCk51CwouQ4+KfuwAoCHl CJbMWou8pgRldA==; In-Reply-To: (message from Pip Cet on Wed, 03 Jul 2024 14:19:02 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321262 Archived-At: > Date: Wed, 03 Jul 2024 14:19:02 +0000 > From: Pip Cet > Cc: Eli Zaretskii , Gerd Möllmann , emacs-devel@gnu.org, eller.helmut@gmail.com > > > No immediate crashes now. > > I will keep this session running, with your patches installed. > > Thanks! Here's what I'm testing now, FWIW. > > Eli, is this sufficiently isolated from the non-MPS case? We use some trivial wrapper macros which become non-trivial in the MPS case, and we always use a slightly more verbose glib function to register handlers (and, in the MPS case, a cleanup handler). I think it's okay, but I'd prefer inline functions instead of macros for glib_user_data and get_glib_user_data. Thanks.