From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] add compiled regexp primitive lisp object Date: Tue, 06 Aug 2024 15:08:01 +0300 Message-ID: <867cctq2fy.fsf@gnu.org> References: <87mslxxddk.fsf@protonmail.com> <5He97LtsyeyQoTLU7d91oP2CLO8s_2afdgcNxozsFjzu8qGbB_7nXmsZL5O6Ej7K-tuEmngCcPKJpDAjxeKz4jk1DvqSUbdOLpw5U1vo1SY=@hypnicjerk.ai> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17066"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pipcet@protonmail.com, emacs-devel@gnu.org To: Danny McClanahan , Stefan Kangas , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 06 14:09:03 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbIzv-0004FG-4U for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Aug 2024 14:09:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbIzB-00049Q-FD; Tue, 06 Aug 2024 08:08:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbIz1-0003b0-3v for emacs-devel@gnu.org; Tue, 06 Aug 2024 08:08:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbIyz-0001OC-0v; Tue, 06 Aug 2024 08:08:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=53gjnEXONeaMHju5hK20pHT0HOTZkAqBbcl6rQEYFzA=; b=NmixAeqFIx6Y 2g2YPe+g/P0jBkkasgBHOp7BSX5xOw14ygj+DiA76vIQuuRHSyvfbRhVdnFLRHCA2KjPOF4OhOOYA aeHPr2/39GqJ6qjPfFsK3zZY0nHk3d6Sa8C5uXDZrzA2yCjpLNhALe48ZFoCOgZjgIOUi0eI1Vzuq TestnzhlG8dnJW5vnBNRYjJWLadyHkPck19hDTixInPEAQKNWRhHkPV19Hs0zOxLX7Snwj7Au0XEa LrhSU9ttfEOfeTFjRQOhormgq04/lKiaxtdd2yVnnfI/m8yVeB0KMWvW/ybgucyPTwI7B4oWlAZk/ fDwJaFOWc60BRO+rjEFmpA==; In-Reply-To: <5He97LtsyeyQoTLU7d91oP2CLO8s_2afdgcNxozsFjzu8qGbB_7nXmsZL5O6Ej7K-tuEmngCcPKJpDAjxeKz4jk1DvqSUbdOLpw5U1vo1SY=@hypnicjerk.ai> (message from Danny McClanahan on Mon, 05 Aug 2024 04:39:14 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322440 Archived-At: > Date: Mon, 05 Aug 2024 04:39:14 +0000 > From: Danny McClanahan > Cc: "emacs-devel@gnu.org" > > Ok, here's a thorough response to this wonderful review from Pip a few days ago: Thanks, but I feel uneasy seeing as we let you work on this more and more as if the patch will be accepted soon, without having the Emacs maintainers state their positions on adding such a feature. Only Andrea expressed his opinion, viz.: > IMO the idea is in principle interesting but: > > Can we prove there is some relistic usecase where we see performance > improvements? Even if we can, maybe we can just improve the caching > mechanism to better work? > > Could you comment on the impact in existing Lisp code? > > IIUC given all methods in methods in search.c would accept Lisp_Regexp > and strings should be limited, but what about other functions returning > regexps like 'regexp-quote'? Should they return now strings or regexps? This seemed to have gone unnoticed. Would you please respond to these comments? FWIW, I had almost the identical thoughts and comments when I read your patches. I'd also like to hear from Stefan Kangas and Stefan Monnier (CC'ed) about their takes from this. I think we should make up our minds about whether we want this feature before Danny invests more efforts in developing it.