From: Eli Zaretskii <eliz@gnu.org>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: emacs-devel@gnu.org, rudalics@gmx.at
Subject: Re: Question about dubious code for terminal frames
Date: Mon, 02 Sep 2024 18:31:39 +0300 [thread overview]
Message-ID: <867cbu842s.fsf@gnu.org> (raw)
In-Reply-To: <m234mi85so.fsf@pro2.fritz.box> (message from Gerd Möllmann on Mon, 02 Sep 2024 16:54:31 +0200)
> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: emacs-devel@gnu.org, rudalics@gmx.at
> Date: Mon, 02 Sep 2024 16:54:31 +0200
>
> > But with the current proliferation of terminal emulators whose window
> > can be resized, what other choice do we have when the only source of
> > information about the resize is SIGWINCH? How else can we update the
> > Emacs notion of the frame's size?
>
> See get_tty_size which the SIGWINCH handler already calls. We could use
> that to get the physical dimension of the terminal.
Get the physical dimensions and then what? We must record the
dimensions in the frames and windows that share that terminal. Which
is what change_frame_size does.
> Outside of get_tty_size I'd make FrameCols/Rows const. I guess that
> frame size changes could remain as is. Only that setting FrameCols/Rows
> is none of their business. It's an input for them, not an output.
Martin will correct me if I'm wrong, but I think the current code
already does what you want: it only changes FrameCols/Rows when the
terminal was really resized.
next prev parent reply other threads:[~2024-09-02 15:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 9:04 Question about dubious code for terminal frames Gerd Möllmann
2024-09-02 9:10 ` Andreas Schwab
2024-09-02 9:48 ` Gerd Möllmann
2024-09-02 10:23 ` Andreas Schwab
2024-09-02 10:46 ` Gerd Möllmann
2024-09-02 11:44 ` Eli Zaretskii
2024-09-02 12:59 ` Gerd Möllmann
2024-09-02 13:17 ` Eli Zaretskii
2024-09-02 14:11 ` Gerd Möllmann
2024-09-02 14:35 ` Eli Zaretskii
2024-09-02 14:54 ` Gerd Möllmann
2024-09-02 15:31 ` Eli Zaretskii [this message]
2024-09-02 15:46 ` Gerd Möllmann
2024-09-02 15:55 ` Eli Zaretskii
2024-09-02 16:24 ` Gerd Möllmann
2024-09-02 16:35 ` Eli Zaretskii
2024-09-02 16:38 ` Gerd Möllmann
2024-09-02 17:39 ` Eli Zaretskii
2024-09-02 16:20 ` martin rudalics
2024-09-02 16:31 ` Gerd Möllmann
2024-09-02 17:32 ` martin rudalics
2024-09-02 18:02 ` Gerd Möllmann
2024-09-02 18:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867cbu842s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).