From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324) Date: Mon, 23 Sep 2024 14:49:12 +0300 Message-ID: <867cb2h9on.fsf@gnu.org> References: <172663360099.23732.9998257239822693024@vcs2.savannah.gnu.org> <20240918042641.56C7BC410E2@vcs2.savannah.gnu.org> <87v7yt322l.fsf@yahoo.com> <87y13kz1ji.fsf@yahoo.com> <4A9D96DA-C260-46B6-A3BC-E2F4A9E5C8E2@gmail.com> <87tte7mlhh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14568"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, luangruo@yahoo.com, stefankangas@gmail.com, emacs-devel@gnu.org To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 23 13:49:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sshZn-0003d6-AX for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Sep 2024 13:49:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sshZA-0000MK-Po; Mon, 23 Sep 2024 07:49:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sshZ6-0000M0-19 for emacs-devel@gnu.org; Mon, 23 Sep 2024 07:49:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sshZ5-0007J0-1A; Mon, 23 Sep 2024 07:49:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=06dfQb5PC2+Qg2xCUTSPbf9Ipept7xqWL0Sahj/ZklI=; b=UNjlW4JqsqUJVXOmukcU kQsz45Q+lJFINC1/vunO/YnrC75uy4eEfsbMyQDOxs5rwCXWKYzRdiciZqFQBX6EZn7PXpKtylvD8 zcdXWlwjNvwZPc9nHRbzfC0DV7kqjrgWKQ5+5zAYIuGfohbdwKC05nYbU3Phfdm/H7ARKDwSu4QT7 0NA7Ab3H0MYw+W57eYk8Qofeu5BxOcZ8QWN19kAMn4r4fZZr1rUbX4e8VKqBVbhshWRgYqLsSyYeC qHYDC99Y5UerwGfyKdYlKkmKmRWxs4UAcltP1TkLoSWjOIQNOysOWZcbRb7Jf8xwsB4zJC55sxc/c Is0/HGYNfKu1Zg==; In-Reply-To: <87tte7mlhh.fsf@gmail.com> (message from =?utf-8?Q?K=C3=A9vin?= Le Gouguec on Sun, 22 Sep 2024 23:23:06 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323955 Archived-At: > From: Kévin Le Gouguec > Cc: Po Lu , Stefan Kangas , > emacs-devel@gnu.org > Date: Sun, 22 Sep 2024 23:23:06 +0200 > > Yuan Fu writes: > > > I took a look and it’s set for log-edit-mode only. It would be nice if magit can pick it up. I’m sure a lot of people (me included) use magit for developing Emacs. The only problem is magit’s commit message editing buffer doesn’t have a special major mode. It does git-commit-mode which is a minor mode, and runs git-commit-setup-hook. But I’m not sure how to edit dir-locals to set fill-column using a hook or minor mode. > > Kludge from my personal config reproduced below¹, if it can help. It > adds a function to git-commit-setup-hook that sets fill-column when it > detects that one of the remotes is Emacs's Savannah repo. > > Thinking more about it, and considering the existence of the > git-commit-major-mode variable, I guess one could also > > 1) define a major mode derived from text-mode in their personal config; > 2) add a .dir-locals-2.el file to their Emacs checkout that sets > git-commit-major-mode to that-new-mode, and fill-column to > *checks config* > 63 > *checks discussion* > ^W64 > *ponders git-blaming to see what Past Self has to say for himself* > *looks at the time* > *you're off the hook, Past Self* > for that-new-mode. Isn't it a bug in magit that it doesn't do something like that already? Fill column is just the tip of an iceberg, because a log message is generally human-readable text, and so should benefit from other features of Text mode and its descendants, like spell-checking etc. Perhaps magit should simply use log-edit-mode? Should we perhaps submit a feature request to the magit developers?