From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use vtable for eww-bookmarks Date: Wed, 06 Nov 2024 16:33:38 +0200 Message-ID: <867c9gsa7x.fsf@gnu.org> References: <86r07osgcj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14849"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, jporterbugs@gmail.com To: =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 06 15:34:35 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t8h7C-0003iv-Tz for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Nov 2024 15:34:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8h6Q-0000lh-I4; Wed, 06 Nov 2024 09:33:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8h6N-0000lQ-Kw for emacs-devel@gnu.org; Wed, 06 Nov 2024 09:33:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8h6N-0003SS-8c; Wed, 06 Nov 2024 09:33:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=gMuBdCIOeHqYaJOcUqLfkpcesxN1hP0czszkXfe27Xw=; b=G4qMtY9CNPEAzBFDFXvN OiXL2ADc6ewt14k8dH2GDi2O5i7Wpdzke4s4QthbeADlIfPMwHscbIvYUb6sEKLta1RolXEUlEIzQ g/t0Dps0heAFxyVXqVPm/Bb53aC5oc2BlzeIwlMNj7S5SOfdX3HkZw8KWDEKl2KPiJQig0FOpvZdr WckTEkKcQXCX4PrZggThl5STEKowd9GytxmCUgFvn07edhYL/n46vxYjsIocNDXv5S0jmyC61z5Fv ivuYLc+Pw0329xQ9HeEMxboPa4MdDGYiXMFQbG73oJbaXaVvNIVX5ErnPYyTOSndH8RQGMdl9IHfH x8yIluMabO9bSg==; In-Reply-To: (message from =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= on Wed, 06 Nov 2024 08:36:00 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325177 Archived-At: > From: Sebastián Monía > Cc: emacs-devel@gnu.org, jporterbugs@gmail.com > Date: Wed, 06 Nov 2024 08:36:00 -0500 > > > I didn't try that, but if it changes the UI and UX, we need to think > > hard whether we want to surprise users with such changes. What's the > > rationale and the motivation for this? > > We decided a few weeks ago that to support reverting, the existing > 'eww-list-buffers' command could be implemented using a "proper table" > mode. The old code worked by inserting text and adding some properties. > > After some conversation we picked vtable for this. The code was marged > recently. > > During that work I noticed 'eww-list-bookmarks' also used this artisanal > approach to building the table, and suggested it would be nice to > convert it to vtable, and make it consistent with the new buffer list. > This is the patch that follows on that suggestion. > > Regarding UI/UX changes, there isn't much of a difference on how the > table looks. The new one supports sorting though. Although I had to add > a binding to "undo sorting", to support an exising feature of > eww-bookmarks that lets you re-order the list. Thanks, then I guess there should be no problems with these changes.