From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: face-remapping-alist client code Date: Mon, 02 Jun 2008 17:28:32 +0200 Message-ID: <8663sr97q7.fsf@lola.quinscape.zz> References: <611w3gcesf.fsf@fencepost.gnu.org> <005201c8c4bb$aec2f580$0200a8c0@us.oracle.com> <87tzgbzyjq.fsf@catnip.gol.com> <87iqwrzwsf.fsf@catnip.gol.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1212420545 1611 80.91.229.12 (2 Jun 2008 15:29:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Jun 2008 15:29:05 +0000 (UTC) Cc: Juanma Barranquero , Drew Adams , emacs-devel@gnu.org To: Miles Bader Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 02 17:29:40 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K3ByU-000075-PQ for ged-emacs-devel@m.gmane.org; Mon, 02 Jun 2008 17:29:31 +0200 Original-Received: from localhost ([127.0.0.1]:54960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3Bxi-0007yt-I1 for ged-emacs-devel@m.gmane.org; Mon, 02 Jun 2008 11:28:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3Bxd-0007wa-3h for emacs-devel@gnu.org; Mon, 02 Jun 2008 11:28:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3Bxb-0007sW-2l for emacs-devel@gnu.org; Mon, 02 Jun 2008 11:28:36 -0400 Original-Received: from [199.232.76.173] (port=55809 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3Bxa-0007s5-SI for emacs-devel@gnu.org; Mon, 02 Jun 2008 11:28:34 -0400 Original-Received: from mail.quinscape.de ([212.29.44.217]:33741) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K3Bxa-0006px-Ps for emacs-devel@gnu.org; Mon, 02 Jun 2008 11:28:35 -0400 Original-Received: (qmail-ldap/ctrl 26258 invoked from network); 2 Jun 2008 15:28:32 -0000 Original-Received: from unknown (HELO lola.quinscape.zz) ([10.0.3.43]) (envelope-sender ) by quinx.quinscape.de (qmail-ldap-1.03) with SMTP for ; 2 Jun 2008 15:28:32 -0000 Original-Received: by lola.quinscape.zz (Postfix, from userid 1001) id 404B88EE8F; Mon, 2 Jun 2008 17:28:32 +0200 (CEST) In-Reply-To: <87iqwrzwsf.fsf@catnip.gol.com> (Miles Bader's message of "Tue, 03 Jun 2008 00:22:40 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-AntiVirus: checked by AntiVir MailGate (version: 2.1.3-2; AVE: 7.8.0.26; VDF: 7.0.4.126; host: quinx) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98238 Archived-At: Miles Bader writes: > "Juanma Barranquero" writes: >> - the variables `text-scale-mode-lighter', >> `text-scale-mode-remapping', `text-scale-mode-amount' and >> `variable-pitch-mode-remapping' would make more sense as >> automatically buffer local, as they are always buffer-local'ized when >> used. > > I somehow got the impression that make-variable-buffer-local was > frowned upon. Dunno if it's true. It depends. If a global value or at least default makes sense of its own, I'd not use make-variable-buffer-local. For values that carry information that only ever makes sense tied to a buffer, I'd use it. This probably implies that it makes more sense with defvar rather than with defcustom. Don't know whether there is a general policy here. -- David Kastrup